Repository navigation
Conversation
|
Other open pull requests touch the same code. Merging one will break the other, or both implement the same thing. If this one builds on them, list them in Depends on.
|
Progress report (a2a3a3a → 286d2c3)📉 System libraries: 87.79% (-0.05%, +2 declared functions) 🆕 2 declared as stubs
|
CnRJay
left a comment
There was a problem hiding this comment.
Same situation as #5123 in this series (see the review there): the names hash correctly, but no title imports these exports yet, and export-only PRs without a title that reaches the export on main have been closed (#1205, #1208, #950). Keeping the names in sce_symbols and reopening once a title's log shows one of them would match current review practice.
|
Closing: no title is known to reach this. With the queue at 700+ open PRs, please hold off on new PRs that don't name a title needing the change until it's down. If a title stops on this on current main, reopen with the title ID and the log line. |
What
Declares 2 exports by name: a virtual-device trigger state and an Aston device-information export. Each is a throwing stub (
NotImplemented_nid_no_patch) declared without parameters, with an Unknown function info entry in its library's technical debt file.wMvV6XbeFd0scePadVirtualDeviceInsertTriggerStateybhL4IoyGZAscePadAstonGetDeviceInformationThe names come from the shared NID database, where I added them (zecoxao/sce_symbols #22 and #23). Each name hashes to its NID with
tools/nid_names.py compute_nid, and the library is the module that exports the NID in the 10.01 system modules.No title I know of imports these yet, so nothing calls them today. With them declared, a title that does import one resolves it by name and stops with that name in the
NotImplementedmessage instead of an unresolved NID at load. Implementations can then replace the stubs one by one.Tested
libstarget builds;tools/check_conventions.py --base origin/mainpasses.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)