Skip to content

feat(libSceAudioPropagation): declare the four query exports by their hash-verified names #5120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
parl0v wants to merge 1 commit into from
Closed

feat(libSceAudioPropagation): declare the four query exports by their hash-verified names #5120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions core/libs/prx/libSceAudioPropagation/Export.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,4 +315,23 @@ std::int32_t APS5_VABI sceAudioPropagationSourceRender(AudioPropagationHandle sy
return 0;
}

int APS5_VABI sceAudioPropagationAudioPathQueryInfo() {
NotImplemented_nid_no_patch(__func__);
return 0;
}

int APS5_VABI sceAudioPropagationMaterialQueryInfo() {
NotImplemented_nid_no_patch(__func__);
return 0;
}

int APS5_VABI sceAudioPropagationPortalQueryInfo() {
NotImplemented_nid_no_patch(__func__);
return 0;
}

int APS5_VABI sceAudioPropagationSourceQueryAudioPaths() {
NotImplemented_nid_no_patch(__func__);
return 0;
}
}
1 change: 1 addition & 0 deletions docs/dev/debt/libSceAudioPropagation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,4 @@

- [sceAudioPropagationSourceSetAudioPath](../../../core/libs/prx/libSceAudioPropagation/Export.cpp) (libSceAudioPropagation, NID `tKSmk2JsMAA`) - `(uint64_t path, const void* data, float gain)` follows [SharpProspero](https://github.com/SvenGDK/SharpProspero/blob/5dfdb4b0b166e83dc9ae275001afb695f12c7174/src/SharpProspero/Interop/Audio/AudioPropagation.cs) and SAROS's call, which passes a handle from `sceAudioPropagationSourceGetAudioPath`, path data and gain 1.0. Path updates are unsupported and every call throws without reading or writing caller memory. The no-propagation model yields no path handles; path allocation, ownership, rendering and console error codes remain unknown.
- [libSceAudioPropagation](../../../core/libs/prx/libSceAudioPropagation/Export.cpp) (libSceAudioPropagation) - signatures and struct descriptors recovered from PPSA21567's calls (#481), not from documentation. The system options layout is unknown (only checked for non-null); the fourth argument of `sceAudioPropagationSourceCalculateAudioPaths` is unknown; `sceAudioPropagationSourceGetAudioPath` is assumed to output an 8-byte path handle. The meaning of the `RenderInfo` word at +0x28 is unknown (PPSA21567 and PPSA21564 pass 2); only 2 is accepted. Both titles pass one `RenderInfo` per call: a count of 0 throws, and larger counts are handled element by element without proof. No error code is known, so invalid input throws instead of returning one
- Declared without parameters, signatures unknown, no title known to import them yet: `sceAudioPropagationAudioPathQueryInfo`, `sceAudioPropagationMaterialQueryInfo`, `sceAudioPropagationPortalQueryInfo`, `sceAudioPropagationSourceQueryAudioPaths` in [libSceAudioPropagation](../../../core/libs/prx/libSceAudioPropagation/Export.cpp) (libSceAudioPropagation). Names from the zecoxao/sce_symbols NID list, each verified against its NID
Loading