Skip to content

feat(libc): use FreeBSD errlst message texts for strerror and strerror_r - #5076

Closed
ErenYeager1836 wants to merge 1 commit into
boykopovar:mainfrom
ErenYeager1836:carry/libc-freebsd-errlst-strerror
Closed

ErenYeager1836 wants to merge 1 commit into
boykopovar:mainfrom
ErenYeager1836:carry/libc-freebsd-errlst-strerror

Conversation

@ErenYeager1836

@ErenYeager1836 ErenYeager1836 commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

What

Aligns libc error message texts in strerror and strerror_r with FreeBSD 11.4 errlst.c.

  • Updates error descriptions for codes 45 through 96 to exact FreeBSD libc strings (including socket shutdown, capability mode, and RPC error descriptions).
  • Extends GuestErrors.cpp tests to verify each error string across all 97 defined values as well as unknown error strings.

Carried from @pushkarreddyy with attribution preserved.

Tested

Linux and Windows: core/libs/tests/GuestErrors.cpp test suite passes, verifying strerror texts across all 97 defined values.

Checklist

  • Based on current main; no other open PR implements the same functions
  • One topic per PR; follow-ups go in a new PR
  • No comments in code except technical debt
  • Unimplemented paths throw (NotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file
  • No notes, investigation .md files or images added to the repository (attach them to this PR)
  • New third-party code is a submodule built from source
  • Generic behaviour, not specific to one title
  • Depends on: none
  • Unblocks: none
  • AI-assisted: yes

Matches FreeBSD 11.4 libc errlst.c message strings for errors 0 through 96, including network socket, RPC, and capability error messages, and tests full array equality in GuestErrors.cpp.
@xXPBSXx

xXPBSXx commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

Review note (static, nothing built): the description says this updates the message texts for codes 45 to 96 and extends GuestErrors.cpp to cover all 97 values, but the diff against current main touches one line of one file: it deletes the comment above messages[] in core/libs/prx/libc/src/Errors.cpp. The FreeBSD errlst texts and the unknown-error tests are already on main (5830d8e44 "use FreeBSD errlst message texts for strerror and strerror_r", 57da6e662 "check the exact unknown-error texts", merged through #3130). If the intent is only the comment removal, the title and description could say that; otherwise the rest of the change may have been dropped in a rebase.

AI-assisted (Claude Code).

@github-actions github-actions Bot added the libc label Oct 13, 2026
@ErenYeager1836

Copy link
Copy Markdown
Contributor Author

Thanks for catching that @xXPBSXx! The FreeBSD errlst message texts were indeed already merged in commit 5830d8e (#3130), so this PR is no longer needed. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants