Repository navigation
refactor(libSceSaveData.native): name sceSaveDataPrepareForTransferring - #4906
Merged
adriadam10 merged 2 commits intoOct 14, 2026
Conversation
The NID RvID8BVeg+g, declared as sceSaveDataUnknown_RvID8BVeg for Minecraft (PPSA17221), hashes to sceSaveDataPrepareForTransferring. The name is not in aerolib; it was found by combining words from the libSceSaveData names that are. Behaviour is unchanged: it still throws, now naming the real function. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017WeVmjnnPPKdxVTpr2Vjtw
Collaborator
|
Checked One fix, pushed as a commit on your branch: the Merging once the full Build is green. |
adriadam10
force-pushed
the
feat/savedata-name-prepare-for-transferring
branch
from
October 14, 2026 17:20
f095791 to
31e53e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Names the libSceSaveData.native NID
RvID8BVeg+g, declared assceSaveDataUnknown_RvID8BVegfor Minecraft (PPSA17221).sceSaveDataPrepareForTransferringhashes to it:The name is not in aerolib (the pinned copy or the current one at
fe2cc2948e). It was found by hashing combinations of the words in aerolib's libSceSaveData names, and it fits beside thesceSaveDataTransferringMountPs4andsceSaveDataDirNameSearchPs4imports it sits next to. As in #1145 and #2301, behaviour is unchanged: it still throws, andNotImplemented_nid_no_patch(__func__)now names the real function. Its arguments stay unknown; the debt entry says so and records where the name came from.Tested
mainc13dc7e:libsbuilds, andnm -DonlibSceSaveData.native.prxshows the exportRvID8BVeg+g.tools/check_conventions.py --base upstream/mainpasses;tools/pr_overlap.pyreports no overlap.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)