Repository navigation
fix(libSceSsl): add missing verification callback export - #4078
Conversation
|
Linux validation on the rebased head passed: GCC 12.2 Release/Ninja built |
|
Which title calls these? On main five of the six are already throwing stubs (#3773), so |
1d6fa73 to
7c05e33
Compare
7c05e33 to
7432518
Compare
7432518 to
5957358
Compare
adriadam10
left a comment
There was a problem hiding this comment.
Thanks for carrying this. Points to address:
- @oneandonlydean's question from 2026-10-12 is still open: five of the six exports are already throwing stubs on main (#3773), so only
sceSslSetVerifyCallbackis missing forffmpeg.prxto load. Please reduce the PR to that one export throwing withNotImplemented_nid_no_patch(__func__); that also drops thelibSceNetlink incore/libs/prx/libSceSsl/CMakeLists.txtand the dependency on #3897. If you keep the full set, name a title that reaches these calls past loading. docs/dev/debt/libSceSsl.md:12and:13are the same line twice.- The PPSA07411 line at
docs/dev/debt/libSceSsl.md:11still listssceSslCreateConnection,sceSslDeleteConnection,sceSslConnect,sceSslReadandsceSslWriteas having no implementation, which this PR makes false (or the reduced PR changes: update it to match). - The checklist says
Depends on: #3897, but the diff doesn't use anything from it; drop it or say what it needs.
|
Thanks, I agree with the scope concern. I do not have a title run showing any of the connection calls executing; the evidence only shows that ffmpeg.prx needs the missing import to load. I will reduce this PR to sceSslSetVerifyCallback as an explicit throwing export, remove the unrelated exports and libSceNet dependency, and fix the duplicated TechnicalDebt line before requesting another review. |
5957358 to
62be5ff
Compare
|
Addressed in |
62be5ff to
6bd44ee
Compare
|
Rebased the reduced one-export change onto current |
Co-Authored-By: Claude <noreply@anthropic.com>
6bd44ee to
e34281b
Compare
adriadam10
left a comment
There was a problem hiding this comment.
Thanks for narrowing this to the one export. Checked: build + guest_ssl green on main plus the PR; guest_ssl fails to link without the change.
Added one commit: docs/dev/debt/libSceSsl.md:12 had also dropped sceSslCreateConnection, sceSslDeleteConnection, sceSslEnableVerifyOption, sceSslConnect, sceSslRead and sceSslWrite, which are still throwing stubs with unknown signatures, so the entry now lists them again next to sceSslSetVerifyCallback. Merging once the full build is green.
What
Adds the missing
sceSslSetVerifyCallbackexport as an explicit throwing stub and pins that behavior inguest_ssl. On currentmain,ffmpeg.prxstill stops at this unresolved import; the other five connection exports already have throwing stubs, so this PR does not repeat them.Why
This is the minimal change needed to resolve the reported
ffmpeg.prximport without claiming that SSL connection behavior is implemented. The callback signature remains unknown, so the export intentionally takes no arguments and throws throughNotImplemented_nid_no_patch.Tested
guest_sslassertion that the export throws; this is coverage included in the PR, not a locally run test result.6bd44ee0bis based on currentmain6e83cad17574960029bdca66626dff57cfb7bb4c.git diff --check upstream/main...HEADpasses. I have not built or run tests on this rebased head.Checklist
#3897dependency