Skip to content

feat(http): add opt-in Windows HTTP and HTTPS transport #3994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aadi-varc wants to merge 4 commits into from
Closed

feat(http): add opt-in Windows HTTP and HTTPS transport #3994

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4fbb076
feat(http): model network handles and request state
aadi-varc Oct 12, 2026
a7925b0
feat(http): add cancellable Windows WinHTTP transport
aadi-varc Oct 12, 2026
941c5e4
refactor(http): dispatch exports to offline and network backends
aadi-varc Oct 12, 2026
2636a48
test(http): cover network requests and skip missing dependencies
aadi-varc Oct 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions core/libs/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,7 @@ if(BUILD_TESTING)
target_link_libraries(guest_offline_imports_tests PRIVATE libSceHttp libSceNpEntitlementAccess libSceRudp libc)
configure_windows_unwind(guest_offline_imports_tests)
add_test(NAME guest_offline_imports COMMAND guest_offline_imports_tests)
set_tests_properties(guest_offline_imports PROPERTIES ENVIRONMENT "APS5_HTTP_NETWORK=0")
if(Python3_Interpreter_FOUND)
add_test(NAME nid_shared_strings COMMAND ${Python3_EXECUTABLE}
${CMAKE_CURRENT_SOURCE_DIR}/nid/tests/test_shared_strings.py $<TARGET_FILE:nid_patcher>)
Expand Down
21 changes: 20 additions & 1 deletion core/libs/prx/libSceHttp/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
add_library(libSceHttp SHARED EXCLUDE_FROM_ALL Export.cpp src/Parse.cpp src/Uri.cpp)
add_library(libSceHttp SHARED EXCLUDE_FROM_ALL Export.cpp src/Parse.cpp src/Uri.cpp src/Network.cpp src/Offline.cpp src/WinHttp.cpp)
target_include_directories(libSceHttp PRIVATE ${LIBS_INCLUDE_DIR})
if(WIN32)
target_link_libraries(libSceHttp PRIVATE winhttp)
endif()
configure_windows_unwind(libSceHttp)

if(BUILD_TESTING)
Expand All @@ -13,6 +16,22 @@ if(BUILD_TESTING)
target_link_libraries(guest_http_response_header_tests PRIVATE libSceHttp libc)
configure_windows_unwind(guest_http_response_header_tests)
add_test(NAME guest_http_response_header COMMAND guest_http_response_header_tests)
set_tests_properties(guest_http guest_http_response_header PROPERTIES ENVIRONMENT "APS5_HTTP_NETWORK=0")
if(WIN32)
if(Python3_Interpreter_FOUND)
add_test_executable(guest_http_network_tests ${LIBS_INCLUDE_DIR}/tests/GuestHttpNetwork.cpp)
target_include_directories(guest_http_network_tests PRIVATE ${LIBS_INCLUDE_DIR})
target_link_libraries(guest_http_network_tests PRIVATE libSceHttp libc)
configure_windows_unwind(guest_http_network_tests)
add_test(NAME guest_http_network COMMAND ${Python3_EXECUTABLE}
${LIBS_INCLUDE_DIR}/tests/http/network.py $<TARGET_FILE:guest_http_network_tests>)
else()
add_test_executable(guest_http_network_missing_python_tests ${LIBS_INCLUDE_DIR}/tests/http/SkipNetwork.cpp)
add_test(NAME guest_http_network COMMAND guest_http_network_missing_python_tests)
endif()
set_tests_properties(guest_http_network PROPERTIES TIMEOUT 30 SKIP_RETURN_CODE 77 ENVIRONMENT_MODIFICATION
"PATH=path_list_prepend:$<TARGET_FILE_DIR:libSceHttp>")
endif()
if(WIN32)
set_tests_properties(guest_http guest_http_response_header PROPERTIES ENVIRONMENT_MODIFICATION
"PATH=path_list_prepend:$<TARGET_FILE_DIR:libSceHttp>")
Expand Down
Loading
Loading