Skip to content

feat(libSceProprietaryVoiceChatHelperPrx): implement the voice chat helper lifecycle - #3826

Closed
semirkabir wants to merge 2 commits into
boykopovar:mainfrom
semirkabir:feat/proprietary-voice-chat-helper-lifecycle
Closed

semirkabir wants to merge 2 commits into
boykopovar:mainfrom
semirkabir:feat/proprietary-voice-chat-helper-lifecycle

Conversation

@semirkabir

@semirkabir semirkabir commented Oct 11, 2026 •

Copy link
Copy Markdown
Contributor

What

Picks up #2796 by @lmaths (auto-closed by the intake pause), rebased onto current main. The only change is a TechnicalDebt.md conflict, resolved by keeping main's libSceHttp entry and adding this library's entry after it.

Implements the no-system-voice-chat path, 0/4 -> 3/4. Initialize and Terminate track whether the library is initialized. SetVoiceChatState returns success and does nothing, because the host has no system voice chat to notify and the state argument is unknown. GetVoiceChatUsageState still throws, since nothing it could report is known. Initializing twice, and any call before Initialize or after Terminate, throws because the library's error codes are unknown. All four signatures are still unknown, and the names come from the aerolib NID list. The library gets its own CMakeLists.txt to register its test, following libSceVoiceQoS.

Tested

Linux x86-64, GCC 14, Release, BUILD_TESTING=ON. guest_proprietary_voice_chat_helper passes, and check_conventions and check_test_registration pass. Not tested with a title.

Checklist

  • Based on current main; no other open PR implements the same functions
  • One topic per PR; follow-ups go in a new PR
  • No comments in code except technical debt
  • Unimplemented paths throw (NotImplemented_nid_no_patch); silent stubs are listed in TechnicalDebt
  • No notes, investigation .md files or images added to the repository (attach them to this PR)
  • New third-party code is a submodule built from source
  • Generic behaviour, not specific to one title
  • Depends on: none
  • AI-assisted: yes

@github-actions

github-actions Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Progress report (24865e8 → 63a573d)

📈 System libraries: 86.29% (+0.09%, +3 implemented functions)

✅ 3 implemented
Library Name
libSceProprietaryVoiceChatHelperPrx sceProprietaryVoiceChatHelperInitialize
libSceProprietaryVoiceChatHelperPrx sceProprietaryVoiceChatHelperSetVoiceChatState
libSceProprietaryVoiceChatHelperPrx sceProprietaryVoiceChatHelperTerminate

@adriadam10

Copy link
Copy Markdown
Collaborator

Checked the build and guest_proprietary_voice_chat_helper (passes, and fails against main's throwing stubs), the TechnicalDebt entry, and the unknown-signature/error-code handling (throws, documented). Added one commit moving the TechnicalDebt line away from the libSceHttp entry, which #3497 edits and conflicted with; scoped build and ctest green after the rebase. Merging.

@github-actions github-actions Bot removed the needs rebase Conflicts with main, rebase needed label Oct 11, 2026
lmaths and others added 2 commits October 11, 2026 22:13
…elper lifecycle

Initialize and Terminate track whether the library is initialized, and
SetVoiceChatState returns success without recording anything: the host has
no system voice chat for a title's own voice chat to announce itself to,
and the state argument is unknown.

GetVoiceChatUsageState keeps throwing. With the state argument unreadable
there is no recorded usage state, and whether the console returns the state
or writes it through an output pointer, and how it encodes it, is unknown.

Misuse throws rather than guessing an error code, as the library's error
codes are unknown.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…bSceHttp entry

Co-Authored-By: Claude <noreply@anthropic.com>
@semirkabir
semirkabir force-pushed the feat/proprietary-voice-chat-helper-lifecycle branch from 0284828 to 63a573d Compare October 11, 2026 22:14
@oneandonlydean

Copy link
Copy Markdown
Collaborator

A title is required for this to merge: which title stops at sceProprietaryVoiceChatHelperInitialize on main? The signatures are unknown, so returning success is a guess until a title shows what it passes and checks. With the title ID and the log line, this can go in.

@lmaths

lmaths commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

@semirkabir can update title pls?

@semirkabir

Copy link
Copy Markdown
Contributor Author

@lmaths I don't have a title that reaches this. Did you pick it up from one? If you have the title ID and the log line where it stops at sceProprietaryVoiceChatHelperInitialize, I'll add it to the Unblocks line. Otherwise this can wait until a bring-up hits it.

@github-actions github-actions Bot added the needs rebase Conflicts with main, rebase needed label Oct 12, 2026

@adriadam10 adriadam10 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up. Two things are needed before this can merge:

  • A title that reaches this library. As @oneandonlydean asked, sceProprietaryVoiceChatHelperInitialize/SetVoiceChatState return success with no known signature, so it is a guess until a title shows what it passes and checks. Please add the title ID and the log line where it stops on main (or a PPSA number plus the call site found in its imports), and put it in the PR body. Without one, this should wait until a bring-up hits it.
  • The branch conflicts with main in docs/dev/TechnicalDebt.md (the libSceHttp entry changed). Please rebase and keep your line away from it.

@oneandonlydean

Copy link
Copy Markdown
Collaborator

Closing: no title is known to reach this. With the queue at 700+ open PRs, please hold off on new PRs that don't name a title needing the change until it's down. If a title stops on this on current main, reopen with the title ID and the log line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build docs needs rebase Conflicts with main, rebase needed prx

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants