Repository navigation
test(shader): cover integer image atomics - #381
asimplestray wants to merge 1 commit into
Conversation
85a2e71 to
2bbb026
Compare
2bbb026 to
1e300bd
Compare
|
Other open pull requests touch the same code. Merging one will break the other, or both implement the same thing. If this one builds on them, list them in Depends on.
|
|
Thanks for this. |
|
As I mentioned on 10-06, If you find a case those tests miss (another dmask or a 64-bit form, for example), a PR adding it there is welcome. If you think I've missed something here, please reopen. |
What
Test-only follow-up: the 6 integer image atomics (
IMAGE_ATOMIC_CMPSWAP/SUB/SMIN/SMAX/INC/DEC) have since landed inmainvia other work with full SPIR-V backend plus a Vulkan execution test, so this PR keeps only the decode-level regression test.Adds the
image_atomicstest (decode opcode + family + image classification plus translation emitting the expected IR op for all 6 encodings, including thedmask=3requirement for cmpswap).Tested
Linux (GCC,
BUILD_TESTING=ON,ANYPS5_ENABLE_SPIRV_TOOLS=OFF): full build, new test passes. Note:agc_driver_pixel_helper_lanesfails on currentmainindependent of this PR (Vulkan pixel-helper assertion, no shader implementation touched here).Checklist
main; no other open PR adds the same test (checked open shader PRs).mdfiles or images added to the repository (attach them to this PR)