Repository navigation
feat(libSceJson2): implement typed construction, indexed and keyed value access, InitParameter2 - #369
Conversation
Progress report (481c85e → fcd349f)📈 System libraries: 82.36% (+0.05%, +9 implemented functions) ✅ 9 implemented
|
|
Thanks for these. Two things before it can go in. It no longer merges into current main: |
|
Other open pull requests touch the same code. Merging one will break the other, or both implement the same thing. If this one builds on them, list them in Depends on.
|
79102c1 to
d22180d
Compare
|
Thanks for the review, both are done:
The CI runs for the new head are waiting for workflow approval. |
|
Thanks, both points are done: the rebase keeps the Since then, main has added four lines at the end of that list ( On #407: it still declares |
…lue access, InitParameter2 Value(ValueType) constructs a value of the given type. getValue(index) and getValue(String) return the element or member, or the null-access result when it is missing, as operator[] does. referValue(index) returns the mutable array element, or null when the value is not an array or the index is out of range, as referValue(String) does for members. Object::size returns the member count. InitParameter2 is the class form of InitParameter: its constructor zeroes it, setAllocator and setFileBufferSize record their arguments, and Initializer::initialize(InitParameter2) succeeds as initialize(InitParameter) does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
d22180d to
fcd349f
Compare
|
Thanks, the rebase is exactly that: main's lines at the end of "Unknown function info" are kept, your |
PPSA12544's Media/Plugins modules (CommonDialog, PSN, Share) import libSceVrSetupDialog, which no library provided, and Share, NpTrophy2, WebBrowserDialog and NpEntitlementAccess functions that were not exported. Add libSceVrSetupDialog and the missing functions as unimplemented exports, except sceNpEntitlementAccessRequestConsumeServiceEntitlement, which reports SCE_NP_ERROR_SIGNED_OUT like sceNpEntitlementAccessRequestConsumeUnifiedEntitlement. Their other imports are covered by #734 and #369, and two by #407. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
What
Nine
libSceJson2exports that had no definition onmain:Value::Value(ValueType)constructs a value of the given type.Value::getValue(size_t)andValue::getValue(const String&)return the element or member, or the null-access result when it is missing, asoperator[]does.Value::referValue(size_t)returns the mutable array element, or null when the value is not an array or the index is out of range, asreferValue(const String&)does for members.Object::sizereturns the member count.InitParameter2(the class form ofInitParameter): the constructor zeroes it,setAllocatorandsetFileBufferSizerecord their arguments, andInitializer::initialize(const InitParameter2*)succeeds asinitialize(const InitParameter*)does. The layout stays within the 40 bytes a title reserves for it on the stack.guest_jsongains a test covering each of them: construction of every type, keyed and indexed reads including missing members and out-of-range indices, writing throughreferValue(size_t), and the recordedInitParameter2fields.Tested
ctest, 107/107 passed.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed in TechnicalDebt.mdfiles or images added to the repository (attach them to this PR)