Repository navigation
feat(libc): implement localeconv - #3310
Closed
renzipego-cpu wants to merge 1 commit into
Closed
renzipego-cpu wants to merge 1 commit into
renzipego-cpu wants to merge 1 commit into
Conversation
|
Thank you for your interest in the project! We are sorry, but we cannot accept more PRs while we work through the existing backlog. This PR has been automatically closed and labeled "intake paused". This is not a judgment of the quality of your changes. |
6 tasks done
9 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resubmits #3245 (closed by the intake rule). Fixes #3249.
What
libc does not export
localeconv(0hlfW1O4Aa4, named with tools/nid_names.py against aerolib).mainstops with:Confirmed on
mainfor:localeconv()takes no arguments and returns a pointer to the standard static C-localelconv(offsets asserted:sizeof == 0x60,decimal_pointat 0x00,negative_signat 0x48,int_frac_digitsat 0x50,int_n_sign_posnat 0x5d); string fields are"."fordecimal_pointand""for the rest, character fieldsCHAR_MAX. Recorded in TechnicalDebt:setlocaleis not supported, so the structure never changes.Note: open PR #545 re-exports this NID from libSceAmpr; this PR implements the libc import the affected titles reference.
Tested
Windows 11, MinGW-w64 GCC 15.2.0 (WinLibs r7), Ninja, Release,
BUILD_TESTING=ON:guest_localepasses (asserts every field value, a stable pointer across calls and thaterrnois untouched).python3 -I tools/check_conventions.py --base origin/mainandtools/check_test_registration.pypass. Titles were not run.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed in TechnicalDebt.mdfiles or images added to the repository (attach them to this PR)