Repository navigation
Conversation
…t their packets sceAgcDcbResetQueue now writes the groups measured on PS5 firmware 13.60 for op bits 0x040 (whole-range ACQUIRE_MEM, CB/DB metadata flushes) and 0x200 (PIXEL_PIPE_STAT_CONTROL), so op 0x3FF writes the measured 61 dwords. The driver reads the envelope's 0xffff1000 NOP as one dword, accepts ACQUIRE_MEM ranges up to 48 bits and accepts PIXEL_PIPE_STAT_CONTROL when it selects the layout the occlusion dump writes. Bit 0x400 still throws. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Thank you for your interest in the project! We are sorry, but we cannot accept more PRs while we work through the existing backlog. This PR has been automatically closed and labeled "intake paused". This is not a judgment of the quality of your changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
sceAgcDcbResetQueuenow writes the packet groups measured on PS5 firmware 13.60 in #1581 for op bits0x040and0x200as well. The driver now accepts every packet in the measured sequence, soop = 0x3FFwrites the console's 61 dwords and the queue runs them. Since #1629, those two bits throw. On top of that, the driver reads the envelope's first dword as a 16K-dword packet (PacketWords(0xffff1000)is0x4001), so any reset fails at submission.Driver (
Pm4):0xffff1000is one dword. It is a type-3 NOP with count0x3FFF. Linux amdgpu pads its rings with exactly this dword (.nop = PACKET3(PACKET3_NOP, 0x3FFF)ingfx_v10_0.c, written one dword at a time byamdgpu_ring_insert_nop), and libSceAgc's own packet-size table already counts it as 1 (tests/PacketInfo.cpp). Only this exact header is treated as filler.ACQUIRE_MEMranges up to 48 bits (COHER_SIZE_HI,COHER_BASE_HI). The0x040group flushes the whole address space withCOHER_SIZE_HI = 0xff. These are the same lines feat(agc): accept the GFX10 packet forms RADV emits #1917 changes, so whichever PR merges second gets a no-op rebase. The range is still not used when the packet runs.EVENT_WRITEPIXEL_PIPE_STAT_CONTROL(event 56, named in Linuxnavi10_enum.h) with event index 1. It is accepted only when it selects the layout the occlusion counter dump (event 57) already writes: Z-pass counter 0, 128-bit stride and the 16 render backendsSampleCounter.compstores. The field layout is Mesa'sPIXEL_PIPE_STATE_CNTL_*insid.h. The measured07fffc00 00000000is that value. Any other counter, stride, backend mask or reserved bit throws.Builder (
libSceAgc): the groups for bits0x040and0x200, as measured in #1581. Bit0x400(opcode0x1E, which the driver does not know) still throws.Seen in PPSA22520 (Animal Well), which calls
sceAgcDcbResetQueue(op = 0x3FF, state = 0)at boot. Onmainit stops with "unsupported op bit 0x40"; with this PR it boots and plays at 60 FPS.Tested
Windows 11, WinLibs GCC 15.2.0, RTX 4070 SUPER.
agc_command_tests: exact bytes forop0x040,0x200and0x3FF(the 61 measured dwords).0x400and0x7FFstill throw and leave the buffer untouched.agc_driver_pm4_tests:PIXEL_PIPE_STAT_CONTROLaccepted with the measured payload, and rejected for each other counter, stride, backend mask, reserved bit, high dword, event index, packet size and the compute queue;ACQUIRE_MEMover 48 bits and both ends of its limit;op = 0x3FFsequence submitted withsceAgcDriverSubmitDcb, followed by a write the queue must reach.mainboth test executables fail.agc_driver_f32_arithmetic_nanfails the same way onmainhere (the NVIDIA driver quiets the NaN).Related: #1581, #1629, #1917 (same
ACQUIRE_MEMlines).Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed in TechnicalDebt.mdfiles or images added to the repository (attach them to this PR)🤖 Generated with Claude Code