Repository navigation
ci: merge train for 4 reviewed PRs (CI batch, do not merge) - #2586
Closed
oneandonlydean wants to merge 10 commits into
Closed
oneandonlydean wants to merge 10 commits into
oneandonlydean wants to merge 10 commits into
Conversation
FreeBSD's unlink ignores the file's own permission bits, so remove() succeeds on a file the guest made read-only with chmod(0400). On Windows the guest chmod sets FILE_ATTRIBUTE_READONLY, and DeleteFileW then fails with ERROR_ACCESS_DENIED, which remove() reported as EACCES. Clear the attribute and retry, restoring it if the retry still fails. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
FreeBSD's gettimeofday stores the time only when tp is not null, and clock_getres the resolution only when res is not null; both succeed otherwise. Both threw, which aborted a title probing a clock or only asking for the time zone. Write into a local result instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
flock_nid_postfix threw on every failure, so a LOCK_NB request on a lock held through another descriptor ended the process. FreeBSD flock(2) returns -1 with EWOULDBLOCK there. Return guest errno 35 when LOCK_NB is set and the host reports the lock as held: ERROR_LOCK_VIOLATION on Windows, EWOULDBLOCK on Linux. Other failures still throw.
The guest filesystem root and the save data directory are taken from the current directory, so an executable started from another directory does not find its title files and keeps saves elsewhere. Make the executable directory the current directory in the Windows entry stub before the system libraries are loaded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI batch for the pull requests below, merged onto main 72ef435 in this order. Do not merge this PR. It exists only so one full build tests them together; each PR is merged on its own after this build is green, and this PR is then closed.