Skip to content

Update Thread.cpp - #2482

Closed
joaofidalgo1998 wants to merge 1 commit into
boykopovar:mainfrom
joaofidalgo1998:jonaschild-patch-1
Closed

joaofidalgo1998 wants to merge 1 commit into
boykopovar:mainfrom
joaofidalgo1998:jonaschild-patch-1

Conversation

@joaofidalgo1998

Copy link
Copy Markdown

used ChatGPT to implement libraries not imported yet (I'm a very inexperienced developer, just got started with C++ 1 month ago so I'm relying alot on AI)

@adriadam10

Copy link
Copy Markdown
Collaborator

Thanks for the contribution. Closing for now, for these reasons:

  • It doesn't compile: PthreadPrivate has no cancelPending member (core/libs/prx/libkernel/Pthread/src/Thread.cpp:523).
  • Even with the member added, nothing reads the flag (scePthreadTestcancel never checks it), so the call would report success without cancelling anything.
  • No tests, and the PR template isn't filled in (see CONTRIBUTING.md).
  • Thread cancellation is already being implemented in feat(libkernel): implement thread cancellation #1141, so this would overlap.

Feel free to reopen once it builds locally, has a test, and doesn't overlap with #1141 (or help review that one).

@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown

Other open pull requests touch the same code. Merging one will break the other, or both implement the same thing. If this one builds on them, list them in Depends on.

Pull request Conflicting files (lines on main) Same exports Same new files
#1739 core/libs/prx/libkernel/Pthread/src/Thread.cpp L520-522

@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown

Progress report (c2f1139 → 13435ff)

📈 System libraries: 85.68% (+0.03%, +1 implemented functions)

✅ 1 implemented
Library Name
libkernel scePthreadCancel

@joaofidalgo1998
joaofidalgo1998 deleted the jonaschild-patch-1 branch October 10, 2026 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants