Skip to content

feat(libScePsml): build libScePsml from the libScePsml_debug source - #2412

Merged
adriadam10 merged 1 commit into
boykopovar:mainfrom
MathiasDevelopes:feat/libscepsml-module
Oct 10, 2026
Merged

adriadam10 merged 1 commit into
boykopovar:mainfrom
MathiasDevelopes:feat/libscepsml-module

Conversation

@MathiasDevelopes

Copy link
Copy Markdown
Contributor

What

Titles that link the release PSML module, libScePsml.prx, failed to start: no host library had that name, and the Windows loader stopped with Failed to load module: ...\libs\libScePsml.prx (error 126). Sword of the Sea (PPSA25344) links it. Only the debug module, libScePsml_debug, existed.

Both modules are now built from the same source. A shared add_sce_psml_library function builds each of them, following the libSceFont / libSceFont-module pattern. PPSA25344 imports nine Mfsr functions from libScePsml. Eight of them already exist. The ninth, scePsmlMfsrGetDispatchMfsrPacket1000, is added without an implementation: it calls NotImplemented_nid_no_patch, and its unknown signature is recorded in TechnicalDebt.

Tested

Windows 11, MinGW-w64 15.2.0. The built libScePsml.prx exports all nine NIDs that PPSA25344 imports from it. guest_psml and patched_libraries pass. The full suite was not run. tools/check_conventions.py --base origin/main passes. PPSA25344 loads libScePsml.prx and continues to engine startup; it does not call the new export there. Not built or run on Linux or macOS.

Checklist

Titles that link the release module libScePsml.prx failed to start
because no host library had that name; PPSA25344 links it. libScePsml
and libScePsml_debug are now built from the same source.
scePsmlMfsrGetDispatchMfsrPacket1000, which PPSA25344 imports, is
added without an implementation.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings October 9, 2026 18:31

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions github-actions Bot added the intake paused Closed while PR intake is limited to authors with at least 10 PRs merged into main label Oct 9, 2026
@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown

Thank you for your interest in the project! We are sorry, but we cannot accept more PRs while we work through the existing backlog. This PR has been automatically closed and labeled "intake paused". This is not a judgment of the quality of your changes.

@github-actions github-actions Bot closed this Oct 9, 2026
@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown

Progress report (f8c2f07 → d5721f3)

📉 System libraries: 84.66% (-0.03%, +1 declared functions)

🆕 1 declared as stubs
Library Name
libScePsml_debug scePsmlMfsrGetDispatchMfsrPacket1000
🔗 1 now sharing sources
Library Name
libScePsml libScePsml_debug

@oneandonlydean oneandonlydean removed the intake paused Closed while PR intake is limited to authors with at least 10 PRs merged into main label Oct 10, 2026
@adriadam10

Copy link
Copy Markdown
Collaborator

Checked on Linux: libScePsml and libScePsml_debug build from the same source, libScePsml.prx exports scePsmlMfsrGetDispatchMfsrPacket1000 and the Mfsr set, patched_libraries, guest_psml and the scoped ctest pass, and the new TechnicalDebt line is in the right section. Merging.

@adriadam10
adriadam10 merged commit a0a6508 into boykopovar:main Oct 10, 2026
17 checks passed
@MathiasDevelopes
MathiasDevelopes deleted the feat/libscepsml-module branch October 10, 2026 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants