Repository navigation
feat(libScePsml): build libScePsml from the libScePsml_debug source - #2412
Merged
adriadam10 merged 1 commit intoOct 10, 2026
Merged
Conversation
Titles that link the release module libScePsml.prx failed to start because no host library had that name; PPSA25344 links it. libScePsml and libScePsml_debug are now built from the same source. scePsmlMfsrGetDispatchMfsrPacket1000, which PPSA25344 imports, is added without an implementation. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Thank you for your interest in the project! We are sorry, but we cannot accept more PRs while we work through the existing backlog. This PR has been automatically closed and labeled "intake paused". This is not a judgment of the quality of your changes. |
Collaborator
|
Checked on Linux: |
11 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Titles that link the release PSML module,
libScePsml.prx, failed to start: no host library had that name, and the Windows loader stopped withFailed to load module: ...\libs\libScePsml.prx(error 126). Sword of the Sea (PPSA25344) links it. Only the debug module,libScePsml_debug, existed.Both modules are now built from the same source. A shared
add_sce_psml_libraryfunction builds each of them, following thelibSceFont/libSceFont-modulepattern. PPSA25344 imports nine Mfsr functions fromlibScePsml. Eight of them already exist. The ninth,scePsmlMfsrGetDispatchMfsrPacket1000, is added without an implementation: it callsNotImplemented_nid_no_patch, and its unknown signature is recorded in TechnicalDebt.Tested
Windows 11, MinGW-w64 15.2.0. The built
libScePsml.prxexports all nine NIDs that PPSA25344 imports from it.guest_psmlandpatched_librariespass. The full suite was not run.tools/check_conventions.py --base origin/mainpasses. PPSA25344 loadslibScePsml.prxand continues to engine startup; it does not call the new export there. Not built or run on Linux or macOS.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed in TechnicalDebt.mdfiles or images added to the repository (attach them to this PR)libScePsml_debug/Export.cpp; whichever lands second needs a small rebase.