Repository navigation
fix(audioout): reject volumes above 0 dB - #2389
Closed
SzymonLeja wants to merge 1 commit into
Closed
SzymonLeja wants to merge 1 commit into
SzymonLeja wants to merge 1 commit into
Conversation
|
Thank you for your interest in the project! We are sorry, but we cannot accept more PRs while we work through the existing backlog. This PR has been automatically closed and labeled "intake paused". This is not a judgment of the quality of your changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
sceAudioOutSetVolumenow rejects invalid volume values below0or above the maximum32768, returning0x80260009(SCE_AUDIO_OUT_ERROR_INVALID_VOLUME) before modifying channel state.Added a regression test covering negative and oversized volumes and verifying that a previously valid volume remains effective. The behavior is independent of PR #1518, and no other open PR implements the same function change.
Tested
Windows 11. No title or homebrew tested.
cmake --build build --target audio_out_mix_level_pad_spk_tests --parallel 2— passedctest --test-dir build -R '^audio_out_mix_level_pad_spk$' --output-on-failure— passed, 1/1cmake --build build --target libs --parallel 2— passedpython tools/check_conventions.py --base origin/main— passedpython tools/check_test_registration.py build— passed; no newly unregistered testsgit diff --check— passedgit show --check --oneline HEAD— passedThe valid range was cross-checked against compatible Vita SDK and shadPS4/OpenOrbis implementations.
Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed in TechnicalDebt.mdfiles or images added to the repository (attach them to this PR)