Repository navigation
test(shader): cover packed half minmax NaN classification - #2314
Closed
JulioCacko wants to merge 1 commit into
Closed
JulioCacko wants to merge 1 commit into
JulioCacko wants to merge 1 commit into
Conversation
Contributor
|
Tested on Linux (CachyOS x86_64, Intel RPL-S iGPU / Mesa 26.3.0-devel / Vulkan 1.4.363, GCC 16.2.1) at
LGTM! |
Collaborator
|
Closing: the expected values come from main's own implementation, so the test passes on main and doesn't check the hardware behaviour. A test measured on hardware would be welcome. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add exact Vulkan regression expectations for packed FP16 min/max with quiet/signalling NaNs in both operands and signs, signed zero, infinity, and ordinary finite values. Explicitly enable
IEEE_MODEfor cases requiring NaN priority, instead of assuming the default shader mode.The local investigation found that checking exponent bits with
0x7c00instead of including the quiet bit (0x7e00) misclassifies 1,022 quiet-NaN patterns across both signs. Current upstream already contains that mask correction inTranslationContext::packedFloat16; this PR contributes regression coverage only. Expected behavior follows the existing upstream packed min/max implementation and float-mode handling; this is not an independent RDNA2 hardware-oracle measurement.Related startup investigation: zero-stride descriptor handling was validated locally using TideOPL's existing PR #1769. Its implementation is excluded from our contributions and remains credited to that PR. Conversion, Vulkan initialization and shader test output do not establish Demon's Souls menus, gameplay, or Gold status.
Tested
Windows 11 x64, MinGW GCC, RelWithDebInfo, NVIDIA GeForce RTX 3070. Focused build passed;
agc_driver_float16_miscpassed 1/1 (1.65 s) withANYPS5_REQUIRE_VULKAN=1, no skip. The branch/title/body conventions check passed. Built and tested with the integrated contribution set on upstreamd70b8998; this branch changes only the FP16 test. This validates the recompiled output on the host GPU, not original RDNA2 instruction execution on an AMD hardware oracle.Checklist
main; open-PR overlap checked before submission