Repository navigation
test(shader): cover SPIR-V 1.3 image compilation without a GPU - #2258
Conversation
|
The exact-head Conventions check fails because the PR body does not fill the template field in its required form. The checker looks for |
|
Checked that this catches #2138 without a GPU. Cherry-picked onto
So the 1.3 path is now covered on CI, where every device targets 1.4. AI-assisted: yes |
|
#2191 is merged, so this passes on main now and fails with the emitter change reverted (run above). Please mark it ready for review. |
|
Checked on main + this PR with SPIRV-Tools on: |
What
Issue #2138's image validation failure depends on the requested SPIR-V version. Existing GPU execution tests can miss it when the available device selects SPIR-V 1.4 or skips execution.
Add a CPU-only regression using the synthetic image-load-and-buffer-store fixture from
ImageSint8.cpp. Compile the real recompiler output against explicit Vulkan 1.1 / SPIR-V 1.3 and Vulkan 1.1 / SPIR-V 1.4 targets, with shader caching disabled. Register default, full and disabled optimization variants when SPIRV-Tools is enabled; each has a 30-second timeout. Validation runs on complete emitted modules before optimization throughRecompile.Depends on #2191. That PR supplies the FMASK predicate correction and the prepared-mesh fixture correction. This PR contains only regression coverage and its build registration; it does not implement those fixes, test the mesh fixture, or claim game/GPU execution correctness.
Tested
maind70b899: the new regression fails in all three optimizer modes with the exact issue diagnostic,Expected vector sizes of Result Type and the condition to be equal: Select.6036d142: Linux 9/9 selected tests passed, zero skipped, 0.48 seconds; Windows 9/9 selected tests passed, zero skipped, 1.02 seconds. The new regression passes in default/full/none modes on both platforms.Checklist