Repository navigation
fix(libkernel): prevent POSIX timed-lock deadline overflow - #2111
Closed
STUPIDCONTEM wants to merge 1 commit into
Closed
STUPIDCONTEM wants to merge 1 commit into
STUPIDCONTEM wants to merge 1 commit into
Conversation
8 of 9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Avoid signed nanosecond overflow when converting absolute POSIX timed-lock deadlines. The shared condition/rwlock/semaphore helper now compares seconds and nanoseconds, computes their nonnegative difference, and clamps before converting to microseconds. The mutex timed-lock wrapper uses the same conversion instead of duplicating the overflowing chrono expression.
A valid distant deadline could previously become negative and cause an immediate ETIMEDOUT. This preserves the existing 32-bit microsecond wait cap, positive submicrosecond truncation, and argument-validation order; it does not extend that maximum wait interval.
FreeBSD stable/11 condition waiting carries the validated absolute timespec into the wait rather than narrowing the epoch to signed nanoseconds. The project represents both timespec fields as signed 64-bit values. Open #2064 and #2067 fix separate equeue/nanosleep conversions; searches found no competing implementation of this helper or the mutex correction.
Tested
Windows 10 Pro 19045, WinLibs GCC 15.2 UCRT posix SEH r7, Release, BUILD_TESTING=ON, main 6cc0503.
No Linux or title execution is claimed for this change.
Checklist