Repository navigation
Conversation
AI-assisted: yes. Implements the reported homebrew import with FreeBSD buffer behavior and the host hostname.
AI-assisted: yes. Builds the implementation and registers guest_hostname with a 20-second timeout.
AI-assisted: yes. Validates native hostname, every boundary capacity, buffer guards, truncation, null queries and thread-local errno.
MarcZX10
left a comment
There was a problem hiding this comment.
I reviewed the complete three-file diff at faba0016408ba09181cbaeef4fb639ee6580a4f7. The null-buffer query path is consistent with the cited FreeBSD implementation, which passes the destination pointer and length to sysctl; Windows' GetComputerNameExA also documents a null-buffer size query. The bounded copy and guest ENAMETOOLONG behavior match the source described in the PR.
Independent Linux/GCC 12.2 validation: guest_hostname is registered and passed (1/1, 0.02 s), check_conventions.py passed, and git diff --check passed. GitHub reports no checks on this head yet. The Windows-specific path remains supported by the author's reported Windows 11 run; I could not execute that path on this Linux host. I found no blocking issue in the diff.
References: FreeBSD gethostname.c (https://raw.githubusercontent.com/freebsd/freebsd-src/main/lib/libc/gen/gethostname.c); Microsoft GetComputerNameExA documentation (https://learn.microsoft.com/en-us/windows/win32/api/sysinfoapi/nf-sysinfoapi-getcomputernameexa).
MarcZX10
left a comment
There was a problem hiding this comment.
The previously reviewed head is unchanged. I confirm the three-file diff and guest_hostname coverage; independent Linux/GCC 12.2 testing passed, and the author reports the Windows hostname path and test pass. The Windows API behavior is supported by the cited GetComputerNameExA docs. GitHub reports no checks for this head, and I cannot run the Windows-specific path in this Linux environment; no blocking issue found.
AI-assisted: yes. Moves hostname test registration to avoid boykopovar#2170 overlap. The full current-main build and focused Windows tests pass; implementation and test source are unchanged.
|
Closing for now: no title stops on The implementation and test look sound. Feel free to reopen when a title's next stop on |
|
This is now a title's next stop on current Checked b9c5a3a merged onto
Example lines for XashPS5 (PPSA19111): This only covers the title-stop half of the close note; the point about handing the host's machine name to the guest is still open. |
|
The host-name exposure is addressed on the updated source branch at a4e3ff0d2. Windows 11, MinGW-w64 GCC 15.2.0, Ninja Release: the complete default build passed with the branch merged into main babyhuey's XashPS5 report supplies the requested runtime-stop evidence for the previous revision. Linux and title retesting of this new hostname policy are still pending; no new title-unblocking claim is made. Could this PR be reopened for review of the updated branch? The closed PR still shows head AI-assisted: yes, OpenAI Codex assisted with the change, tests, validation and this comment. |
|
@QRMOE same question as on #2024: |
|
@babyhuey Yes, please go ahead and open it from your fork. Please preserve my original commits and authorship, credit @QRMOE in the new PR description, and retain the original author credit if rebasing or squashing. My preference is the fixed guest name The full Windows build passed with main Thank you for helping carry this forward. Please link the replacement PR here so I can follow it. AI-assisted: yes, OpenAI Codex assisted with the implementation, validation and this reply. |
|
@QRMOE opened as #2968 from your updated branch (a4e3ff0, the fixed |
What
Updated source branch: a4e3ff0d2. GitHub still shows the previous closed PR head
b9c5a3a8; a maintainer needs to reopen the PR to refresh its diff. The behavior and validation below describe the updated source branch.Implements
gethostname(-nvxBWa0iDs) with the stable guest hostnameAnyPS5. The guest receives this name on every host; the implementation never queries or copies the PC's DNS hostname, Unix nodename or environment. This addresses the host-name exposure raised in the close note.Preserves the existing FreeBSD buffer behavior: bounded copying, guest
ENAMETOOLONG=63, null-buffer queries and unchanged guest errno on success. There are no host API calls or dynamic allocations in the implementation. Tests now verify the guest identity, buffer guards, every capacity from zero through hostname length + 2, maximumsize_tcapacity, null queries, success errno and thread-local error isolation. TechnicalDebt records the fixed-name policy and unverified console hostname configuration and sysctl/resolver integration.babyhuey's report supplies the requested current-main failure: XashPS5 (PPSA19111) stops at missing
gethostname, and the previous branch moves it to missingrealpathon Linux and Windows. That report tested the previous head, before this identity change; it is third-party evidence and has not been independently rerun here. No claim that this revision starts the title is made.Tested
Windows 11, WinLibs MinGW-w64 GCC 15.2.0 UCRT/POSIX/SEH, Ninja Release;
BUILD_TESTING=ON,ANYPS5_ENABLE_SPIRV_TOOLS=ON.guest_hostnameandguest_errorseach passed five consecutive runs with this fix.5edae35361e9b7f7061f28c6e80ed075312b8105. On that tree,guest_hostnameandguest_errorseach passed five consecutive runs; a second build had no work to do.a4e3ff0d2bee6582651fa876f1a0e188b93cf2e6includes current main. Its complete source tree exactly matches the tree used for the successful full build and focused tests.Not tested: Linux or macOS for this revision, console, games or the complete CTest suite. Previous Linux approvals and title reports apply to the earlier head.
Checklist
main; no other open PR implements the same functions