Repository navigation
Conversation
AI-assisted with Codex.
This was referenced Oct 8, 2026
|
Other open pull requests touch the same code. Merging one will break the other, or both implement the same thing. If this one builds on them, list them in Depends on.
|
9 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Implement the 13 existing Vdecsw exports for queued progressive 8-bit 4:2:0 AVC using the existing FFmpeg dependency. Own padded access-unit copies, provide completion/output queues, enforce memory and output bounds, and support drain/reset/deletion. An original bounded H.264 parser snapshots SPS/PPS/slice/VUI/SEI metadata per input; FFmpeg retains it through B-frame reordering so timestamps and picture information remain attached to the correct frame.
ABI references are pinned SharpProspero/shadPS4 declarations. Parsing follows ITU-T H.264 (08/2021), with exact clauses and limitations in TechnicalDebt. No third-party decoder-wrapper implementation was copied.
Tested
Windows x86-64, WinLibs MinGW-w64 GCC 15.2.0, Release. This topic is based on upstream main ce64d8e. Runtime results below come from the integrated checkout; the isolated source checks are described separately. The final integrated Release build and library target passed, with 504/506 CTests passing: only the pre-existing shader_clock and vopc_compare_table GPU failures remain. No new failures were observed.
guest_avplayer, guest_videodec2, guest_avc_metadata and guest_vdecsw all pass (4/4). Synthetic fixtures check decoded pixel hashes, B-frame ordering, timestamps/crop metadata, input ownership, queue limits, reset under backpressure, lifetime races, structure canaries and malformed metadata. Parser boundary and mutation regressions pass. Full build/libs, conventions, registration and export inspection pass; only 13 guest APIs are exported.
HEVC, VP9, interlace and extended configurations remain explicit errors. Caller memory queries cover HLE objects; FFmpeg dynamic allocations are host-owned. Console queue policies, full profile/level conformance and allocation-size parity remain unverified. No PS5 hardware, retail title or Linux runtime validation was performed.
Isolated publication-source check: all 5 affected production/test compile configurations pass with this branch's own core headers, excluding neighboring local topics. Conventions, diff checks and source/test registration review also pass. Dependency headers and generated configuration come from the existing pinned build; a new full configure/link/runtime run was not performed for this isolation check.
Checklist