Skip to content

fix(libc): correct guest exception callback ABI on Windows #1840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oneandonlydean merged 2 commits into from
Oct 10, 2026
Merged

fix(libc): correct guest exception callback ABI on Windows #1840

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a961ad3
fix(libc): bridge guest message exception destructors
Prophet069 Oct 8, 2026
05e1cf9
fix(libc): bridge guest exception vtable callbacks
Prophet069 Oct 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions core/libs/prx/libc/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,6 +373,31 @@ if(BUILD_TESTING)
endif()

if(MINGW)
if(BUILD_TESTING)
enable_language(ASM)
add_test_executable(guest_message_destructor_abi_tests
${LIBS_INCLUDE_DIR}/tests/GuestMessageDestructorAbi.cpp
${LIBS_INCLUDE_DIR}/tests/GuestMessageDestructorAbi.S)
target_include_directories(guest_message_destructor_abi_tests PRIVATE ${LIBS_INCLUDE_DIR})
target_link_libraries(guest_message_destructor_abi_tests PRIVATE libc)
configure_windows_unwind(guest_message_destructor_abi_tests)
foreach(mode IN ITEMS control decoy zero release regex-decoy regex-zero
unshared-decoy unshared-zero regex-unshared-decoy regex-unshared-zero)
add_test(NAME guest_message_destructor_${mode} COMMAND guest_message_destructor_abi_tests ${mode})
set_tests_properties(guest_message_destructor_${mode} PROPERTIES TIMEOUT 10
ENVIRONMENT_MODIFICATION "PATH=path_list_prepend:$<TARGET_FILE_DIR:libc>")
endforeach()
foreach(kind IN ITEMS message plain)
foreach(operation IN ITEMS what destroy delete)
foreach(register IN ITEMS decoy zero)
set(mode "vtable-${kind}-${operation}-${register}")
add_test(NAME guest_exception_${mode} COMMAND guest_message_destructor_abi_tests ${mode})
set_tests_properties(guest_exception_${mode} PROPERTIES TIMEOUT 10
ENVIRONMENT_MODIFICATION "PATH=path_list_prepend:$<TARGET_FILE_DIR:libc>")
endforeach()
endforeach()
endforeach()
endif()
foreach(runtimeLinkFlag IN ITEMS -static-libgcc -static-libstdc++ -static)
string(REPLACE "${runtimeLinkFlag}" "" CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS}")
endforeach()
Expand Down
Loading
Loading