Repository navigation
Conversation
This was referenced Oct 8, 2026
kali113
marked this pull request as ready for review
October 8, 2026 21:18
9 tasks done
Progress report (a8b032b → 6e6ee7e)📈 System libraries: 84.79% (+0.03%, +6 implemented functions) ✅ 6 implemented
|
8 tasks done
Every 8- and 16-bit BDA store and the unaligned path of every 32-bit store emitted one get_bda_write_pointer lookup and one note_bda_write per byte at the store site, five write lookups per 32-bit store. They now call write_bda_bytes, which loops over the bytes and does, per byte and in order, the same lookup, the store when it is mapped and the write note, so faults are recorded exactly as before. On an RTX 3060 the agc_driver_flat_store binaries shrink from 496,256 to 138,240 bytes (wave32) and from 928,384 to 225,152 bytes (wave64), and the cold run from 19.7 s to 2.2 s.
note_bda_write unrolled its 8 compare-exchange probes, and drivers inline it at every BDA store and atomic. The probes now run in a loop that tries the same slots in the same order and stops at the same slot, so the recorded pages and the overflow flag are unchanged. With the byte store helper, the agc_driver_flat_store binaries on an RTX 3060 go from 138,240 to 75,648 bytes (wave32) and from 225,152 to 130,560 bytes (wave64), and the cold run from 2.2 s to 1.2 s.
… path The declaration, the state field and the definition of write_bda_bytes now sit next to EmitBdaStore and the other BDA write functions instead of next to the dword read functions, which boykopovar#1267 extends at the same lines. No change to the emitted code.
Collaborator
|
Closing: ProsperoRadio (PPSA99001) stops on the missing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add six
libSceOpusCeltDeclifecycle and decode exports backed by official libopus 1.6.1, pinned as a source submodule. The implementation decodes CELT-only raw packets to 48 kHz mono/stereo signed 16-bit interleaved PCM, validates decoder ownership and byte capacity, and copies PCM only after successful decoding. Unsupported modes and invalid calls throw; no console error codes are guessed.The fork branch
kali113:feat/opus-celt-dechas been rebuilt as one decoder-only commit (e3b8ae75) onmaind70b8998. It contains none of #1265, #1913, #1986 or #1999. An old branch backup remains available locally. There are no shader or unrelated test changes in that candidate. GitHub retains the old commit/diff snapshot on this closed PR; review the cleaned branch comparison or linked candidate commit rather than this closed PR's historical Files changed tab.The public ProsperoRadio caller at 2c4029c declares this interface; published decoder research describes the context pointer, caller allocation and byte counts. These sources establish the caller contract, not bit-exact console equivalence. Console state layout, context values and error behavior remain unverified and are recorded in TechnicalDebt.
This PR remains closed pending the runtime evidence requested in the closing review. The earlier description overstated readiness. ProsperoRadio normally opens the general
libSceOpusDecdecoder first; its production dispatch retries CELT only after a particular general-decoder error and a CELT packet. Main currently lacks the general decoder, proposed separately in #1823. No title log demonstrates reaching the CELT calls on current main, and this patch does not establish radio playback or a significant library-coverage increase. A reopened submission needs a real title's next-stop log on main.Duplicate recheck: reviewed file lists for all 538 current open PRs, including the complete 1,203-file list of #1128. Only #1823 touches an Opus decoder module; it implements the separate general decoder, not these CELT exports. Its commits are not included here.
Tested
Candidate
e3b8ae7511a17ea3c4f4d1e47e60f94ed3e887ae:7f1b5e3fand explicitly checks out candidatee3b8ae75; the workflow is not part of the contribution.python3 tools/check_conventions.py --base d70b89989473ba1f6ae13e44e079e67f1f8a44b0passes.Checklist
main; no other open PR implements the same functions.mdfiles or images added to the repository