Skip to content

feat(libc): implement floating minmax #1770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MarcZX10 wants to merge 1 commit into from
Closed

feat(libc): implement floating minmax #1770

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions core/libs/prx/libc/src/Math.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,10 @@ float APS5_VABI atanf_nid_postfix(float x) { return std::atan(x); }
double APS5_VABI atan2_nid_postfix(double y, double x) { return std::atan2(y, x); }
float APS5_VABI powf_nid_postfix(float base, float exp) { return std::pow(base, exp); }
double APS5_VABI pow_nid_postfix(double base, double exp) { return std::pow(base, exp); }
double APS5_VABI fmin_nid_postfix(double x, double y) { return std::fmin(x, y); }
double APS5_VABI fmax_nid_postfix(double x, double y) { return std::fmax(x, y); }
float APS5_VABI fminf_nid_postfix(float x, float y) { return std::fmin(x, y); }
float APS5_VABI fmaxf_nid_postfix(float x, float y) { return std::fmax(x, y); }
float APS5_VABI expf_nid_postfix(float x) { return std::exp(x); }
float APS5_VABI exp2f_nid_postfix(float x) { return std::exp2(x); }
float APS5_VABI logf_nid_postfix(float x) { return std::log(x); }
Expand Down
13 changes: 13 additions & 0 deletions core/libs/tests/GuestMath.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,10 @@ float APS5_VABI tanf_nid_postfix(float);
float APS5_VABI log10f_nid_postfix(float);
float APS5_VABI logbf_nid_postfix(float);
double APS5_VABI exp2_nid_postfix(double);
double APS5_VABI fmin_nid_postfix(double, double);
double APS5_VABI fmax_nid_postfix(double, double);
float APS5_VABI fminf_nid_postfix(float, float);
float APS5_VABI fmaxf_nid_postfix(float, float);
double APS5_VABI ldexp_nid_postfix(double, int);
double APS5_VABI scalbn_nid_postfix(double, int);
float APS5_VABI scalbnf_nid_postfix(float, int);
Expand Down Expand Up @@ -201,6 +205,15 @@ int main() {
Require(logbf_nid_postfix(-std::numeric_limits<float>::infinity()) == std::numeric_limits<float>::infinity());
Require(std::isnan(logbf_nid_postfix(std::numeric_limits<float>::quiet_NaN())));
Require(exp2_nid_postfix(-3.) == 0.125);
const double doubleNan = std::numeric_limits<double>::quiet_NaN();
const float floatNan = std::numeric_limits<float>::quiet_NaN();
Require(fmin_nid_postfix(3.0, -2.0) == -2.0 && fmax_nid_postfix(3.0, -2.0) == 3.0);
Require(fminf_nid_postfix(3.0f, -2.0f) == -2.0f && fmaxf_nid_postfix(3.0f, -2.0f) == 3.0f);
Require(fmin_nid_postfix(doubleNan, 4.0) == 4.0 && fmax_nid_postfix(4.0, doubleNan) == 4.0);
Require(fminf_nid_postfix(floatNan, 4.0f) == 4.0f && fmaxf_nid_postfix(4.0f, floatNan) == 4.0f);
Require(std::isnan(fmin_nid_postfix(doubleNan, doubleNan)) && std::isnan(fmaxf_nid_postfix(floatNan, floatNan)));
Require(std::isinf(fmin_nid_postfix(-std::numeric_limits<double>::infinity(), 1.0)));
Require(std::isinf(fmaxf_nid_postfix(std::numeric_limits<float>::infinity(), 1.0f)));
Require(ldexp_nid_postfix(0.75, 4) == 12.);
Require(scalbn_nid_postfix(0.75, -2) == 0.1875);
Require(scalbnf_nid_postfix(0.75f, 4) == 12.f);
Expand Down