refactor(recompiler): share the control flow helpers

[LeandroLP23]

What

Eight helpers were defined with identical bodies in the anonymous namespaces of two of the three control flow sources:

Helper	Copies
addUnique, sortUnique, remapId, remapIds, rebuildPredecessors	GraphBuilder.cpp, Structurizer.cpp
contains, intersectSorted	ControlFlowGraph.cpp, Structurizer.cpp
toHexString	ControlFlowGraph.cpp, GraphBuilder.cpp

• They are declared in a new ControlFlow/ControlFlowHelpers.hpp and defined once in ControlFlowGraph.cpp; bodies are unchanged
• Only ControlFlowGraph.cpp, GraphBuilder.cpp and Structurizer.cpp include the header. It is not added to ControlFlowGraph.hpp, which eight recompiler sources include, since generic names such as contains would then meet the helpers and calls of that name in other components
• RdnaDecoder keeps its own toHexString, which is in an anonymous namespace and does not clash

No behaviour change.

Tested

Windows 11, MinGW-w64 GCC 15.2.0 (WinLibs r7), Release with BUILD_TESTING=ON. No title or homebrew.

• The removed text in each file was checked to be exactly the moved body; each helper had exactly two copies.
• Full build, no new warnings.
• Full ctest on an AMD Radeon 860M, main ac951f8: 425/426 passed; the failure is agc_driver_vopc_compare_table fails in wave32 for LG compares in the e32 encoding on AMD RDNA 3.5 #825 (agc_driver_vopc_compare_table, fixed by fix(shader): emit ordered not-equal through an integer NaN check #1473), which also fails on unmodified main on this GPU.
• Full ctest on lavapipe (Mesa 26.2.4, selected with VK_DRIVER_FILES), before the rebase onto ac951f8: 424/424 passed, 22 skipped for its 8-lane subgroups.
• The two open PRs that touch these files, feat(shader): translate s_swappc_b64 fetch-shader calls at vertex entry #1217 and feat(shader): decode s_rfe_b64, s_sethalt, s_sendmsghalt and s_code_end #1306 (GraphBuilder.cpp), merge without conflicts with this change. No open PR adds its own copy of these helpers.

Checklist

• Based on current main; no other open PR implements the same functions
• One topic per PR; follow-ups go in a new PR
• No comments in code except technical debt
• Unimplemented paths throw (NotImplemented_nid_no_patch); silent stubs are listed in TechnicalDebt
• No notes, investigation .md files or images added to the repository (attach them to this PR)
• New third-party code is a submodule built from source
• Generic behaviour, not specific to one title
• Depends on: none
• AI-assisted: yes

🤖 Generated with Claude Code

[klosixgaming-arch]

Good refactoring that extracts common control flow helper functions into a dedicated header file. This eliminates code duplication across GraphBuilder.cpp, Structurizer.cpp, and ControlFlowGraph.cpp.

Strengths:

• Clean separation of concerns with dedicated helper functions (toHexString, contains, intersectSorted, addUnique, sortUnique, remapId, remapIds, rebuildPredecessors)
• Proper use of existing standard library algorithms
• No behavioral changes, just code organization improvement
• Good header file design with appropriate includes

This will improve code maintainability by centralizing common control flow utilities. Ready to merge.

[adriadam10]

Checked that every removed body is identical to the moved one, only the three control flow sources include the new header, and there is no behaviour change. Built on top of current main and ran the AGC/AgcDriver ctest set on Linux: all green. Merges cleanly with #2276, #2257, #2201, #2105 and #1836; CI is green on the head. Merging.