Repository navigation
Conversation
|
Other open pull requests touch the same code. Merging one will break the other, or both implement the same thing. If this one builds on them, list them in Depends on.
|
This was referenced Oct 7, 2026
Collaborator
|
Thanks for the PR. I'm closing this one, for two reasons:
If a title stops at one of the marker span functions on main, please add the title ID and that log line on #971. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Implements
sceAgcDcbPushMarkerSpan,sceAgcDcbSetMarkerSpan,sceAgcAcbPushMarkerSpan, andsceAgcAcbSetMarkerSpaninlibSceAgc.(cb, marker, length, color)follow OpenAGC (include/agcdriver.handsrc/cb_builders.c), which document the explicit-length marker variants for DCB and ACB.sceAgcDcbPushMarker,sceAgcDcbSetMarker,sceAgcAcbPushMarker, andsceAgcAcbSetMarker.0x10, sub-opcode0x0bfor push,0x0cfor pop) with explicit length bounds, ensuring payload zero-padding and null-termination.TechnicalDebt.mdin the same commit.Tested
/tmp/anyps5_build.core/libs/prx/libSceAgc/tests/Commands.cpp(testMarkersinagc_commands):PushMarkerSpan.SetMarkerSpanemits matching push and pop packets for DCB and ACB.ctest -R agc_commands.python3 tools/progress.pyconfirmslibSceAgcprogress improved from 199 to 202 implemented functions (4 stubs resolved).Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed in TechnicalDebt.mdfiles or images added to the repository (attach them to this PR)