Repository navigation
Conversation
softprops/action-gh-release v2 runs on Node 20, which GitHub now forces onto Node 24 with a deprecation warning; v3 is the Node 24 line with the same inputs. zip.yml never set up Node, so the release ZIP's assets were built with whatever the runner image defaults to. It now reads .nvmrc like the test jobs. .nvmrc, the engines field and the README move from 20 to 24. Build and tsc pass locally on Node 24.21.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
softprops/action-gh-releasev2 → v3. v2 runs on Node 20, which GitHub forces onto Node 24 with a deprecation warning (seen on the 1.0.10 release run). v3 is the Node 24 line with the same inputs.zip.ymlnow sets up Node from.nvmrc. It never did, so the release ZIP's assets were built on the runner image's default Node..nvmrc,enginesand the README move from 20 to 24.Every other action was already on its Node 24 major.
bun run buildandtsc --noEmitpass locally on Node 24.21.