[skyshab]

Linear: CONS-505 — WorkOS Integration - Admin Settings - Users tab settings do not save

Problem

On WorkOS → Settings → Users, clicking Save Settings did nothing and no changes persisted (logout redirects, deprovision action, reassign user, role map — all silently dropped).

Root cause

The Users tab is wrapped in the WordPress Settings API form:

<form action="options.php" method="post">
    settings_fields( 'workos_settings' );
    do_settings_sections( 'workos-users' );  // renders all sections
    submit_button( 'Save Settings' );        // the Save button
</form>

render_role_map() (the last section) emitted its own <form> for the "Sync Roles to WorkOS" button — nested inside that outer form. Browsers don't allow nested forms: the HTML parser ignores the inner <form> open tag but honors its </form>, which closes the outer settings form early. Because Role Mapping is the last section, the submit_button() that follows ends up outside the form, so clicking it submits nothing and options.php never runs.

This is the same class of bug as the earlier "unnest Create Organization modal so settings save works" fix (#6) — that one was missed on the role-sync form. Only the Users tab was affected (the other tabs have no nested form), and only when the plugin is enabled with an org configured (the condition that renders the sync button).

Fix

Mirror the existing modal pattern:

• Defer the sync <form> to admin_footer so it sits at body level, not nested in the settings form (render_role_sync_form()).
• Keep the visible "Sync Roles to WorkOS" button in the actions row, wired to that form via the HTML5 form="workos-role-sync-form" attribute.

The settings form stays intact; Save works. The role-map JS still finds the settings form via table.closest('form'), so its duplicate-role submit guard keeps working.

Testing

• Verified locally (Lando): on the Users tab, changing a logout redirect / deprovision action / role mapping and clicking Save Settings now persists across a refresh. Confirmed the "Sync Roles to WorkOS" button still submits to admin-post.php via the footer form.
• php -l clean.

🤖 Generated with Claude Code