add linux arm64 driver url for chrome - #1630
Merged
Merged
Conversation
Owner
|
Thanks a lot, @Blaubeeree, for contributing. The code looks good but there is a failing test in CI: Can you please check it? |
Contributor
Author
|
The problem seemed to be that the mac and linux github runner have Chrome 152 installed while the driver exists only since Chrome 153 (didn't even knew the driver was this new 😄 ). |
Owner
|
Thanks a lot for contributing, @Blaubeeree! |
Contributor
Author
|
No problem, thanks for the quick response and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of changes
Add the URL to download chrome on linux arm64 systems
Types of changes
How has this been tested?
Executed the Unittests in ChromeDriverManagerTest and ChromeArmTest