Repository navigation
Conversation
Owner
|
Is it possible to have a test ? |
Author
|
Do you mean a code test or a real-world test? |
There was a problem hiding this comment.
Pull request overview
Adds outbound proxy support for connecting to target RDP hosts via ALL_PROXY / all_proxy (SOCKS5 and HTTP/HTTPS CONNECT) within the rdpgw protocol processing path.
Changes:
- Add
golang.org/x/net/proxyandgo.connect-proxy-scheme, registeringhttp/httpsdialer types. - Switch RDP target connection establishment from
net.DialTimeoutto proxy-aware dialing. - Update module dependencies to include new direct and transitive requirements.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| go.mod | Adds proxy-related modules and updates indirect dependencies required by the new proxy dialer support. |
| cmd/rdpgw/protocol/process.go | Registers HTTP/HTTPS CONNECT proxy dialers and uses proxy-aware dialing for target connections. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow connecting to hosts behind a SOCKS5 or HTTP/HTTPS proxy.
Usage: setting environment variable
all_proxyorALL_PROXY