feat: support xml+svg and svg - #119
Open
Blooym wants to merge 1 commit into
Open
Conversation
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a more complete implementation of SVG support that supersedes #115 and #73.
This matcher is correctly able to detect both and + combinations by reading ahead in the buffer by up to 256 bytes when an xml tag is detected - this read-ahead amount should be low enough to avoid false detections in other file formats while still detecting XML+SVG correctly.
Two sample files have been been added alongside test cases for both SVG detections and for ensuring text-based XML still works as expected by excluding SVG.
resolves #60