Repository navigation
Conversation
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR implement/change/remove?
First slice of the #442 split, per the request there to start small and only add core interfaces that every Redfish-backed provider can implement through
redfishwrapper/gofish.Adds the standard three-layer bmclib capability, following the shape of
bmc/secure_boot.go(#457):internal/redfishwrapper:GetPowerMetrics/SetPowerCapover gofishChassis.Power(). ReadsPowerControl[0](consumed watts, capacity watts,PowerLimit.LimitInWatts). The cap is written with a PATCH ofPowerControl[0].PowerLimit.LimitInWatts;nilsendsnulland clears the cap. gofish exposes noUpdate()on thePowerresource, hence the explicit PATCH.bmc:PowerMetricsGetter/PowerCapSetterinterfaces, thePowerMetricsstruct (consumed, capacity, limit) and the usualFromInterfacesdispatch.Client.GetPowerMetrics/Client.SetPowerCappassthroughs;FeatureGetPowerMetrics/FeatureSetPowerCap.Wired into every provider that embeds
redfishwrapper.Client-redfish,dell,supermicroandlenovo- plus anexamples/power-capexample (get / set / clear).One commit per layer for review.
Checklist
The HW vendor this change applies to (if applicable)
Any BMC reached via the generic Redfish, Dell, Supermicro, or Lenovo XCC provider.
The HW model number, product name this change applies to (if applicable)
Validated on hardware: Lenovo ThinkSystem SR630 V2 (XCC). Dell and Supermicro wiring is covered by fixture tests only (same as the Lenovo wiring in #457).
The BMC firmware and/or BIOS versions that this change applies to (if applicable)
Requires the Redfish
Powerresource underChassiswith aPowerControlmember. Validated against XCC Redfish 1.14.0.What version of tooling - vendor specific or opensource does this change depend on (if applicable)
gofish (already a direct dependency,
github.com/stmcginnis/gofish/schemas).Description for changelog/release notes