feat: add bearer/basic auth support to webhook notifications (#2369) - #3802
feat: add bearer/basic auth support to webhook notifications (#2369)#3802jannikbx wants to merge 6 commits into
Conversation
Add optional authentication to webhook notifications:
- webhookAuthType field ('none' | 'basic' | 'bearer')
- Basic Auth: base64-encoded username:password header
- Bearer Token: Authorization header with token
Closes bluewave-labs#2369
|
Hey @smz202000, YoinkingFishy mentioned that #3785 and my PR (#3802) are both implementing #2369, so we should probably coordinate before either gets merged. Quick status check from my side: my PR has all CI checks green and no open review comments so far. Yours still has a few open items – the changes ajhollid requested, and the format checks are still failing. How do you want to handle this? Either you finish those up on #3785 and we align the field names so yours can get merged, or I adapt my PR to match your naming and add the client-side part. I'm fine with either – just don't want us to block each other. Let me know what works for you! |
…auth Completes bearer/basic auth support for webhook notifications (Closes bluewave-labs#2369) Signed-off-by: OpenClaw <openclaw@bluewavelabs.io>
…refactor) Signed-off-by: OpenClaw <openclaw@bluewavelabs.io>
Signed-off-by: OpenClaw <openclaw@bluewavelabs.io>
|
Hi maintainers! This PR is now complete and ready for review. It implements bearer/basic auth for webhook notifications (#2369). What's included:
Happy to adjust based on feedback. Thanks! |
…omplete # Conflicts: # server/src/domain/notifications/notification.model.ts # server/src/domain/notifications/notification.type.ts
Fixes #2369 - Adds optional authentication to webhook notifications.
Changes
WebhookAuthType(none|basic|bearer) and auth fields toNotificationinterfacegetAuthHeaders()toWebhookProviderfor Basic Auth (base64) and Bearer tokensendMessage()andsendTestAlert()How it works
Basic Auth: Notification gets
webhookAuthType: "basic",webhookAuthUsername,webhookAuthPassword→ sendsAuthorization: Basic <base64>Bearer: Notification gets
webhookAuthType: "bearer",webhookAuthToken→ sendsAuthorization: Bearer <token>None: No auth fields → no Authorization header (unchanged behavior)