Skip to content

Fix Server URL field to be editable #3256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Aryan1718 wants to merge 6 commits into
base: develop
Choose a base branch
from
+10 −2
Open

Fix Server URL field to be editable #3256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c6e58ef
Fix Server URL field to be editable
Aryan1718 Feb 9, 2026
3340420
Fix Server URL field to be editable
Aryan1718 Feb 9, 2026
1f12340
Fix Server URL field to be editable
Aryan1718 Feb 9, 2026
1f4126e
Address PR review feedback for editable server URL
Aryan1718 Apr 12, 2026
02d32be
Merge upstream develop into fix/edit-url
Aryan1718 Apr 12, 2026
b8447f8
Format CreateMonitor alert condition
Aryan1718 Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions client/src/Pages/CreateMonitor/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { logger } from "@/Utils/logger";
import { useParams, useLocation, useNavigate } from "react-router";
import { useForm, Controller } from "react-hook-form";
import { zodResolver } from "@hookform/resolvers/zod";
import { useTheme } from "@mui/material";
import { useTheme, Alert } from "@mui/material";
import Stack from "@mui/material/Stack";
import RadioGroup from "@mui/material/RadioGroup";
import FormControl from "@mui/material/FormControl";
Expand Down Expand Up @@ -209,6 +209,7 @@ const CreateMonitorPage = () => {
}, [defaults, form]);

const watchedType = watch("type") as MonitorType;
const watchedUrl = watch("url");

const watchedUseAdvancedMatching = watch("useAdvancedMatching") as boolean;
const watchGeoCheckEnabled = watch("geoCheckEnabled") as boolean;
Expand Down Expand Up @@ -374,13 +375,17 @@ const CreateMonitorPage = () => {
fieldLabel={generalSettingsConfig.urlLabel}
placeholder={generalSettingsConfig.urlPlaceholder}
fullWidth
disabled={isEditMode}
error={!!fieldState.error}
helperText={fieldState.error?.message ?? ""}
/>
)}
/>
)}
{isEditMode && existingMonitor && watchedUrl !== existingMonitor.url && (
<Alert severity="warning">
{t("pages.createMonitor.form.general.url.alert")}
</Alert>
)}

{/* Port field - only for port and game types */}
{generalSettingsConfig.showPort && (
Expand Down
3 changes: 3 additions & 0 deletions client/src/locales/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -505,6 +505,9 @@
"placeholder": "wss://example.com/socket"
}
},
"url": {
"alert": "The dashboard will now pull its data from the updated URL."
},
"title": "General settings",
"description": {
"http": "Enter the URL or IP to monitor (e.g., https://example.com/ or 192.168.1.100) and add a clear display name that appears on the dashboard.",
Expand Down
Loading