Repository navigation
fix(wallet): hide unusable linked US banks and allow relinking - #75
Merged
Merged
Conversation
A linked US bank only counts as an ACH source when both the account and the Plaid link are active. Failed links are hidden from account lists and no longer block linking a new bank to the same pocket.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The wallet treated any linked US bank with an active Plaid link as usable, and showed failed links like any other product:
linkStatus: activebutstatus: creation_in_progresscould be picked as the ACH source, and the order would fail.creation_failedstatus.Linear: https://linear.app/bloque/issue/BQE-2657/wallet-no-debe-mostrar-cuentas-bancarias-vinculadas-que-no-estan
How it works
New
src/domain/accounts/external-us-bank.tsdefines the linked-bank states once:status: activeandlinkStatus: activestatus: creation_failedorlinkStatus: link_failedstatus: creation_in_progresswithlinkStatus: activeScreens use these helpers instead of checking
linkStatusalone.Changes
useAccountPicker:requireLinkStatusreplaced byrequireUsableUsBank.Dev requirements
None. US rails are still behind
US_RAILS_ENABLED = false, so only the account pages change visibly today.Risk
external-us-bankrow in mediums. Keeping only one live row per ledger is backend work, tracked in BQE-2732.