feat(desktop): require Goose 1.44.0 for managed agents - #3830
Closed
lifeizhou-ap wants to merge 3 commits into
Closed
feat(desktop): require Goose 1.44.0 for managed agents#3830lifeizhou-ap wants to merge 3 commits into
lifeizhou-ap wants to merge 3 commits into
Conversation
Signed-off-by: Lifei Zhou <lifei@squareup.com>
Signed-off-by: Lifei Zhou <lifei@squareup.com>
…imal-version * origin/main: (37 commits) fix(catalog): update Amp tagline (block#3806) fix(desktop): channel topic and membership metadata cleanup (block#3642) fix(desktop): align data deletion labels (block#2230) fix(relay): align NIP-11 max_limit with REQ ceiling (block#3635) fix(desktop): allow linux-only media items as dead code off-linux (block#3811) fix(desktop): report authenticated relay recovery (block#3812) fix(desktop): don't gate hover affordances on the hover media query (block#3657) feat(relay): gate kind 30178 team-catalog reads behind the shared tag (block#3358) test(desktop): click visible thread collapse guide (block#3800) feat(desktop): raise the install ceiling and make installs observable (block#3368) fix(db): isolate usage metrics advisory-lock test on scratch DB (block#3670) Add Devin as a preset ACP harness (block#3225) feat(desktop): improve agent activity header ui (block#3321) perf(presence): reduce heartbeat frequency (block#3783) Tighten continuation message rows (block#3724) Fix video reviews in thread replies (block#3719) feat(release): make desktop releases immutable (block#3568) Make relay reconnect backoff authoritative (block#3774) feat(desktop): add password-protected backups in settings (block#3701) fix(desktop): reuse profiles when joining communities (block#2155) ... Signed-off-by: Lifei Zhou <lifei@squareup.com> # Conflicts: # desktop/src-tauri/src/commands/agent_discovery.rs # desktop/src-tauri/src/managed_agents/discovery.rs # desktop/src-tauri/src/managed_agents/types.rs # desktop/src/features/settings/ui/HarnessCatalogDialog.tsx # desktop/src/features/settings/ui/HarnessRow.tsx # desktop/src/shared/api/tauri.ts # desktop/src/shared/lib/configNudge.ts
Author
|
🤖 Superseded by #3839. The replacement keeps Goose updates optional in Settings and removes minimum-version enforcement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cli_outdatedand offer an update using the resolved Goose binaryPreviously, runtime discovery treated any resolved Goose binary as available. That allowed unsupported Goose versions to pass setup and fail later without a clear upgrade path. This change detects the version during discovery, fails closed when it cannot be compared, and guides the user through updating and post-install verification.
Related issue
None found.
Testing
just desktop-checkjust desktop-test— 3,867 passedjust desktop-tauri-clippyjust desktop-tauri-test— 2,006 passedcargo test --manifest-path desktop/src-tauri/Cargo.toml goose— 33 passedNo screenshot included: the affected states require an outdated local Goose installation, and the copy/state transitions are covered by focused UI tests.