Skip to content

[pm-38360] feat: Adds new Date Field Picker to new cipher types - #2942

Open
morganzellers-bw wants to merge 6 commits into
mainfrom
morgan/pm-38360-new-item-datepicker
Open

[pm-38360] feat: Adds new Date Field Picker to new cipher types#2942
morganzellers-bw wants to merge 6 commits into
mainfrom
morgan/pm-38360-new-item-datepicker

Conversation

@morganzellers-bw

@morganzellers-bw morganzellers-bw commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-38360

📔 Objective

Add the new DateFieldPicker to the Add/Edit screens of the new cipher types License and Passport.

Also update the label styling to match the other fields in the Add/Edit Item screen.

📸 Screenshots

Click to reveal Screenshots

Updated Label Style

Before After
picker_before picker_after

Updated Screens

Picker Expanded Passport Collapsed
picker_expanded passport_collapsed

@morganzellers-bw
morganzellers-bw force-pushed the morgan/pm-38360-new-item-datepicker branch from 2d4f969 to ea8bc25 Compare August 7, 2026 20:01
@github-actions github-actions Bot added app:password-manager Bitwarden Password Manager app context app:authenticator Bitwarden Authenticator app context t:feature labels Aug 7, 2026
@codecov

codecov Bot commented Aug 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.78947% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.48%. Comparing base (c694ae8) to head (8323f29).

Files with missing lines Patch % Lines
ViewInspectorTestHelpers/InspectableView.swift 64.28% 5 Missing ⚠️
...I/Platform/Application/Views/DateFieldPicker.swift 87.50% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2942   +/-   ##
=======================================
  Coverage   79.47%   79.48%           
=======================================
  Files        1172     1172           
  Lines       75139    75180   +41     
=======================================
+ Hits        59715    59755   +40     
- Misses      15424    15425    +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…elected date

The Form Values section formatted the UTC-anchored stored date with an
implicit local time zone, rolling the displayed day back by one on time
zones behind UTC. Format via the shared longCalendarDateDisplay helper
instead, matching how the real app displays these dates.
@morganzellers-bw morganzellers-bw self-assigned this Aug 7, 2026
@morganzellers-bw morganzellers-bw added the ai-review-vnext Request a Claude code review using the vNext workflow label Aug 7, 2026
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Claude Code is reviewing this pull request...

If this comment does not update with results, check the Actions log.

@morganzellers-bw morganzellers-bw added ai-review-vnext Request a Claude code review using the vNext workflow and removed ai-review-vnext Request a Claude code review using the vNext workflow labels Aug 10, 2026
@morganzellers-bw
morganzellers-bw marked this pull request as ready for review August 10, 2026 14:35
@morganzellers-bw morganzellers-bw removed the app:authenticator Bitwarden Authenticator app context label Aug 10, 2026
@github-actions github-actions Bot added the app:authenticator Bitwarden Authenticator app context label Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review-vnext Request a Claude code review using the vNext workflow app:authenticator Bitwarden Authenticator app context app:password-manager Bitwarden Password Manager app context t:feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant