Skip to content

[PM-41830] Shrinking Window Causes Buttons to Overlap Owner Element and Pushes More Options Menu Offscreen - #22419

Open
jengstrom-bw wants to merge 1 commit into
mainfrom
vault/pm-41830/shrinking-window-causes-buttons-to-overlap-owner-element-and-pushes-more-optinos-menu-offscreen
Open

[PM-41830] Shrinking Window Causes Buttons to Overlap Owner Element and Pushes More Options Menu Offscreen#22419
jengstrom-bw wants to merge 1 commit into
mainfrom
vault/pm-41830/shrinking-window-causes-buttons-to-overlap-owner-element-and-pushes-more-optinos-menu-offscreen

Conversation

@jengstrom-bw

Copy link
Copy Markdown
Contributor

🎟️ Tracking

Jira

📔 Objective

When shrinking the desktop window, the buttons will eventually overlap the Owner column elements and will push the More Options three dot menu offscreen. The overlap happens on both Login and Card ciphers, but the More Options issue only happens on Login ciphers. This PR fixes the overlap and pushing issues.

📸 Screenshots

Screen.Recording.2026-08-13.at.3.39.01.PM.mov

@jengstrom-bw jengstrom-bw added ai-review-vnext Request a Claude code review using the vNext workflow t:bugfix Change Type - Bugfix labels Aug 13, 2026
@github-actions

github-actions Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed the desktop vault-v3 list column sizing fix: the Name column becomes the flexible column (tw-w-full) while Owner and Options reserve fixed px widths, and the Owner column's container-query breakpoint moves from @md to @xl in the header and both row templates so header and body stay in sync. Verified bit-table renders a single tw-w-full tw-table-fixed table (so the header cells govern the virtual-scrolled rows), that the mixed percentage/px column pattern already ships in the web vault table, that @xl resolves from @tailwindcss/container-queries defaults under the existing tw-@container wrapper with no containers theme override, and that tw-w-56/tw-w-40 written as string literals in the .ts are covered by the desktop Tailwind content globs. Also confirmed the new showQuickCopyActions signal mirrors VaultCipherRowComponent's flag-plus-setting check, that quick copy renders at most three icons (Login) so the 224px budget holds, that VaultCopyButtonsService is providedIn: "root", and that the removed showExtraColumn has no remaining desktop references.

Code Review Details

No findings.

@codecov

codecov Bot commented Aug 13, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 40.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.94%. Comparing base (c8fd6e8) to head (eebf1cb).
⚠️ Report is 8 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...top/src/vault/app/vault-v3/vault-list.component.ts 40.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #22419      +/-   ##
==========================================
+ Coverage   53.92%   53.94%   +0.01%     
==========================================
  Files        4297     4297              
  Lines      136500   136508       +8     
  Branches    21569    21570       +1     
==========================================
+ Hits        73612    73639      +27     
+ Misses      57522    57503      -19     
  Partials     5366     5366              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jengstrom-bw
jengstrom-bw marked this pull request as ready for review August 14, 2026 15:20
@jengstrom-bw
jengstrom-bw requested a review from a team as a code owner August 14, 2026 15:20
export const RowHeightClass = `tw-h-[76.5px]`;

/**
* Width of the Options column, sized to the widest action strip a row can draw.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 Documentation is appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review-vnext Request a Claude code review using the vNext workflow t:bugfix Change Type - Bugfix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants