Skip to content

[PM-41829] Login Buttons Overlap Owner and Name Elements When Resizing Browser - #22418

Draft
jengstrom-bw wants to merge 2 commits into
mainfrom
vault/pm-40548/login-buttons-overlap-owner-and-name-elements
Draft

[PM-41829] Login Buttons Overlap Owner and Name Elements When Resizing Browser#22418
jengstrom-bw wants to merge 2 commits into
mainfrom
vault/pm-40548/login-buttons-overlap-owner-and-name-elements

Conversation

@jengstrom-bw

Copy link
Copy Markdown
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-41829

📔 Objective

When shrinking the browser window, the login button elements overlap the Name and Owner elements. This PR fixes the column width when the quick copy actions are enabled.

📸 Screenshots

Screen.Recording.2026-08-13.at.2.06.14.PM.mov

@jengstrom-bw jengstrom-bw added ai-review-vnext Request a Claude code review using the vNext workflow t:bugfix Change Type - Bugfix labels Aug 13, 2026
@github-actions

github-actions Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

This bugfix replaces the inline ngClass width expression on the vault items options column with a optionsColumnWidthClass() helper that widens the column when the quick copy icons are enabled (tw-w-48) versus the combined copy menu (tw-w-32), keeping the existing batch-bar/tw-w-12 behavior when copy and launch actions are off. VaultCopyButtonsService is injected via inject() and combined with the PM40435_QuickCopyIconSetting flag, matching the pattern already used in vault-cipher-row.component.ts. Test providers were added in both affected specs, and the new unit tests cover the three width branches. No security, correctness, or breaking-change concerns were identified.

Code Review Details

No findings met the confidence threshold for posting.

Notes considered and dropped as non-issues:

  • The widened column when copy/launch actions are enabled (tw-w-28tw-w-32/tw-w-48) also applies when the batch bar is enabled; this matches the prior behavior where the copy/launch branch took precedence.
  • VaultCopyButtonsService is providedIn: "root", and the two specs that instantiate VaultItemsComponent were updated; the org collections vault spec overrides its template, so it is unaffected.
  • Tailwind scans .ts files in apps/web, so the class name literals returned from the helper are not purged.

@codecov

codecov Bot commented Aug 13, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.92%. Comparing base (7fc22e3) to head (432dbbb).
⚠️ Report is 3 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...lt/components/vault-items/vault-items.component.ts 66.66% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #22418      +/-   ##
==========================================
+ Coverage   53.84%   53.92%   +0.07%     
==========================================
  Files        4293     4297       +4     
  Lines      136324   136506     +182     
  Branches    21546    21572      +26     
==========================================
+ Hits        73410    73616     +206     
+ Misses      57551    57522      -29     
- Partials     5363     5368       +5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review-vnext Request a Claude code review using the vNext workflow t:bugfix Change Type - Bugfix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant