Skip to content

[PM-41902] Member Access Report terminology changes - #22410

Merged
JaredScar merged 3 commits into
mainfrom
ac/pm-41902-member-access-report
Aug 17, 2026
Merged

[PM-41902] Member Access Report terminology changes#22410
JaredScar merged 3 commits into
mainfrom
ac/pm-41902-member-access-report

Conversation

@JaredScar

Copy link
Copy Markdown
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-41902

📔 Objective

Fixes up the terminology for VFO 1 on the Member Access Report which was missed in initial scope

📸 Screenshots

image

…proved clarity and consistency. Adjusted terminology from "collections" to "shared folders" in the HTML template and refined the English message for member access reporting in the JSON locale file.
@JaredScar JaredScar added the ai-review Request a Claude code review label Aug 13, 2026
@JaredScar
JaredScar requested a review from a team as a code owner August 13, 2026 19:27
@JaredScar JaredScar added the t:feature Change Type - Feature Development label Aug 13, 2026
@JaredScar
JaredScar requested a review from Banrion August 13, 2026 19:27
@github-actions

github-actions Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed a VFO1 terminology update for the Member Access Report: the flagged page description key was replaced (memberAccessReportPageDescV2memberAccessReportPageDescV3, with the orphaned V2 entry removed from the en source locale), and the collections table header now resolves through the vfo1I18n pipe with the existing sharedFolders key. Verified Vfo1I18nPipe is declared in the component's imports, that both sharedFolders and memberAccessReportPageDescV3 exist in apps/web/src/locales/en/messages.json, and that the pipe falls back to the legacy key when VFO1Foundation is off, so unflagged users keep the current copy. No remaining references to memberAccessReportPageDescV2 exist in apps, libs, or bitwarden_license; the leftover copies in non-en locale files are Crowdin-managed and harmless. The earlier DEBT finding on the unreferenced V2 key has been addressed in the latest commit.

@codecov

codecov Bot commented Aug 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.97%. Comparing base (cca2f6e) to head (74af1c1).
⚠️ Report is 27 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #22410      +/-   ##
==========================================
+ Coverage   53.64%   53.97%   +0.32%     
==========================================
  Files        4287     4302      +15     
  Lines      136053   136630     +577     
  Branches    21496    21580      +84     
==========================================
+ Hits        72982    73741     +759     
+ Misses      57727    57510     -217     
- Partials     5344     5379      +35     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…nsistency. Changed the reference in the HTML template to the latest description version and added a new entry in the JSON locale file for improved clarity.
Comment thread apps/web/src/locales/en/messages.json Outdated
@JaredScar
JaredScar merged commit 77b8418 into main Aug 17, 2026
77 of 82 checks passed
@JaredScar
JaredScar deleted the ac/pm-41902-member-access-report branch August 17, 2026 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review t:feature Change Type - Feature Development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants