Skip to content

[PM-41909] Remove desktop UI settings dialog feature flag - #22402

Open
djsmith85 wants to merge 6 commits into
mainfrom
ps/pm-41909/remove-desktop-ui-settings-dialog-feature-flag
Open

[PM-41909] Remove desktop UI settings dialog feature flag#22402
djsmith85 wants to merge 6 commits into
mainfrom
ps/pm-41909/remove-desktop-ui-settings-dialog-feature-flag

Remove unused method to open modals. Modals should be replaced by dia…

1e1b775
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 18, 2026 in 1s

54.01% (-0.04%) compared to 8711032

View this Pull Request on Codecov

54.01% (-0.04%) compared to 8711032

Details

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 54.01%. Comparing base (8711032) to head (1e1b775).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/desktop/src/app/app.component.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #22402      +/-   ##
==========================================
- Coverage   54.05%   54.01%   -0.04%     
==========================================
  Files        4307     4306       -1     
  Lines      136733   136465     -268     
  Branches    21609    21577      -32     
==========================================
- Hits        73910    73711     -199     
+ Misses      57430    57364      -66     
+ Partials     5393     5390       -3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.