Repository navigation
Add veto event before portal domain redirects - #666
Merged
Merged
Conversation
mesilov
marked this pull request as ready for review
September 30, 2026 07:37
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A cross-domain HTTP 302 currently repeats the API call with OAuth credentials before applications can intervene. Add
PortalDomainUrlChangingEventbefore credential mutation and the retry. A listener can calldeny()to reject the transition withPortalDomainChangeRejectedException(aPortalUnavailableExceptionsubclass), retaining the current domain and sending no request to the denied destination.The first denial wins. Stopping event propagation alone does not veto a transition. Existing automatic following without a denial and the post-success
PortalDomainUrlChangedEventremain compatible. This is an application-controlled veto, not a default destination restriction. Seedocs/portal-domain-redirects.mdfor builder wiring, exception handling and multi-hop behavior.Test plan
make lint-cs-fixermake lint-rectormake lint-phpstanmake lint-deptracmake test-unit— 1964 tests, 6492 assertions; exit 0 with 11 deprecations. The new focused tests emit none.make test-file path=tests/Integration/Core/CoreTest.php— 3 tests, 3 assertions.make test-integration-core— 24 tests, 3174 assertions, one error and one failure: the 2510-contact fixture hit the portal operation-time limit during deletion; ScopeTest found catalog drift (aiassistant,biconnectormobile,bizprocdesigner,mailsender). Those source/test files are unchanged from the base. This PR remains draft because the full gate is not green.Closes #632
Generated with Codex using the repository b24phpsdk-maintainer workflow.