Skip to content

ENH: Adding Mixture-Class for superposition of priors - #1118

Open
Hen42rik wants to merge 8 commits into
bilby-dev:mainfrom
Hen42rik:combined-priors
Open

ENH: Adding Mixture-Class for superposition of priors#1118
Hen42rik wants to merge 8 commits into
bilby-dev:mainfrom
Hen42rik:combined-priors

Conversation

@Hen42rik

Copy link
Copy Markdown
Contributor

This is a new PR for the same suggested addition of #1077, but addressing the following additional aspects:

  1. as requested by @fgittins , the Prior class is renamed to Mixture
  2. as requested by @fgittins , it is refactored to inherit most methods from the Interped class
  3. the interface is adjusted to respect the new xp_wrap decorators

The original

@Hen42rik

Copy link
Copy Markdown
Contributor Author

I would consider this now complete, but happy to consider further remarks @fgittins @mj-will
P.S: Sorry for the delay, holiday

@mj-will mj-will added priors enhancement New feature or request >100 lines labels Aug 25, 2026
@mj-will
mj-will requested review from a team and fgittins August 25, 2026 10:13
@GregoryAshton

Copy link
Copy Markdown
Collaborator

@Hen42rik this also seems to be doing some rewriting of _split_repr which I think was used to ensure the written repr could be used to reconstruct the prior. I do see extensions to the tests, but I'm trying to figure out if there are any edge cases we need to add. Just leaving this as a comment to discuss

@Hen42rik

Copy link
Copy Markdown
Contributor Author

@GregoryAshton I agree that some pitfalls might be hidden here. I have spent some extra time to make sure some of the previously skipped prior tests are now performed, too, but I am not able to vow for this to not break something. I think someone more familiar with these edge cases would probably be more suitable to suggest additional required tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants