Skip to content

Replace static models with enums - #241

Open
yannik131 wants to merge 4 commits into
masterfrom
1048-remove-static-models
Open

Replace static models with enums#241
yannik131 wants to merge 4 commits into
masterfrom
1048-remove-static-models

Conversation

@yannik131

Copy link
Copy Markdown

Child PR of biigle/core#1048 for maia module

@yannik131
yannik131 force-pushed the 1048-remove-static-models branch from 81771f6 to 70c6e72 Compare August 31, 2026 16:44
@yannik131

yannik131 commented Aug 31, 2026

Copy link
Copy Markdown
Author

The plan is:

  • Delete FK creations in old migrations referencing deleted tables
  • Add a migration dropping existing FKs referencing deleted tables
  • Update the rest of the code to not reference deleted tables

For deployment:

  • update biigle app code
  • migrate maia first since FK are onDelete('restrict')
  • then migrate the biigle app

@yannik131
yannik131 marked this pull request as ready for review September 1, 2026 21:48
@yannik131

Copy link
Copy Markdown
Author

@mzur Tests are locally passing with the branch from biigle/core#1551. I haven't tested maia yet though because I've never used it and first have to figure out how. I'm not sure if the tests alone are reason enough to believe everything is working. If you can easily test this locally, let me know, otherwise I'll try to test it. Ready for review.

@yannik131
yannik131 requested a review from mzur September 1, 2026 21:50
Comment thread requirements.txt

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

torchvision 0.27.1 depends on torch 2.12.1, the current requirements.txt can't be installed like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant