Fix 6784#6821
Draft
artpelling wants to merge 2 commits into
Draft
Conversation
|
Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry. |
Author
Contributor
The issue with that PR wasn't the fix itself. It was that the author used AI to generate and submit a large number of pull requests with little apparent human involvement. We're generally fine with using LLMs as development tools, but we don't want communication or contributions to be entirely AI-generated. Our policy is outlined here: https://github.com/beetbox/beets?tab=contributing-ov-file#notes-on-ai-usage. |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #6784 .
I (and others) encountered an issue where playlist queries returned empty results. At first, I thought it was because I had playlist in extended m3u format. I found that the line skipping mechanism did not work correctly because the playlist file is read as bytestrings and the comparator used regular strings.
Fixing that did not help (the previously unskipped lines were simply not found but did not break the search) and I then found #6784. I think the issue there is that different path normalizations are used in
beets lsandplaylist.py.To Do
docs/to describe it.)docs/changelog.rstto the bottom of one of the lists near the top of the document.)