feature/DEVSU-3000-add-endpoint-to-get-all-therapeutic-targets - #503
Open
sshugsc wants to merge 4 commits into
Open
feature/DEVSU-3000-add-endpoint-to-get-all-therapeutic-targets#503sshugsc wants to merge 4 commits into
sshugsc wants to merge 4 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #503 +/- ##
===========================================
- Coverage 76.96% 76.93% -0.04%
===========================================
Files 188 189 +1
Lines 6895 6910 +15
Branches 880 880
===========================================
+ Hits 5307 5316 +9
- Misses 1490 1496 +6
Partials 98 98 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Adds a new admin-only API endpoint to retrieve therapeutic targets across all reports, wiring it into the main API router and updating ACL rules to restrict access.
Changes:
- Added
GET /api/therapeutic-targetsroute to fetch therapeutic targets (including associated report ident). - Registered the new route in the central routes index.
- Updated ACL special cases to require
adminfor the new endpoint.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| app/routes/therapeuticTargets.js | Introduces the new global therapeutic-targets GET endpoint and query logic. |
| app/routes/index.js | Mounts the therapeutic-targets router under the API routes. |
| app/middleware/acl.js | Restricts GET /api/therapeutic-targets to admins via ACL special-case rules. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
elewis2
requested changes
Aug 5, 2026
elewis2
left a comment
Collaborator
There was a problem hiding this comment.
sorting by rank issue noted by copilot?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DEVSU-3000