Skip to content

feature/DEVSU-3000-add-endpoint-to-get-all-therapeutic-targets - #503

Open
sshugsc wants to merge 4 commits into
developfrom
feature/DEVSU-3000-add-endpoint-to-get-all-therapeutic-targets
Open

feature/DEVSU-3000-add-endpoint-to-get-all-therapeutic-targets#503
sshugsc wants to merge 4 commits into
developfrom
feature/DEVSU-3000-add-endpoint-to-get-all-therapeutic-targets

Conversation

@sshugsc

@sshugsc sshugsc commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

DEVSU-3000

  • add endpoint for therapeutic targets

@github-actions

This comment has been minimized.

@codecov-commenter

codecov-commenter commented Jul 30, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 60.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.93%. Comparing base (bec6af0) to head (2ffe50c).

Files with missing lines Patch % Lines
app/routes/therapeuticTargets.js 53.84% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #503      +/-   ##
===========================================
- Coverage    76.96%   76.93%   -0.04%     
===========================================
  Files          188      189       +1     
  Lines         6895     6910      +15     
  Branches       880      880              
===========================================
+ Hits          5307     5316       +9     
- Misses        1490     1496       +6     
  Partials        98       98              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sshugsc
sshugsc requested review from bnguyen-bcgsc and elewis2 July 30, 2026 23:33

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new admin-only API endpoint to retrieve therapeutic targets across all reports, wiring it into the main API router and updating ACL rules to restrict access.

Changes:

  • Added GET /api/therapeutic-targets route to fetch therapeutic targets (including associated report ident).
  • Registered the new route in the central routes index.
  • Updated ACL special cases to require admin for the new endpoint.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
app/routes/therapeuticTargets.js Introduces the new global therapeutic-targets GET endpoint and query logic.
app/routes/index.js Mounts the therapeutic-targets router under the API routes.
app/middleware/acl.js Restricts GET /api/therapeutic-targets to admins via ACL special-case rules.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread app/routes/therapeuticTargets.js
Comment thread app/routes/index.js
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@elewis2 elewis2 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorting by rank issue noted by copilot?

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

Unit Test Results

    1 files  ±0    64 suites  ±0   3m 52s ⏱️ -2s
656 tests ±0  655 ✔️ ±0  1 💤 ±0  0 ❌ ±0 
650 runs  ±0  649 ✔️ ±0  1 💤 ±0  0 ❌ ±0 

Results for commit 2ffe50c. ± Comparison against base commit bec6af0.

@sshugsc
sshugsc requested a review from elewis2 August 5, 2026 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants