Release/v8.6.0 - #501
Open
kttkjl wants to merge 40 commits into
Open
Conversation
- Add migrations to add new legends table and rework pathway analysis legend column - Add new table to store pathway analysis legends - Rework association column between pathway analysis and legends - Add unit tests for new legends endpoints - Update swagger documentation for new legends endpoints - Update mockReportData json with test legend image
Master-to-dev-8.5.0
…-to-IPR-api feature/DEVSU-2914-add-exon-column-to-IPR-api
feature/DEVSU-2928-datafix-seqqc
…t-getting-populated bugfix/DEVSU-2931 updated_by is not getting populated during user creation
…ove-on-rerank [DEVSU-2953] add hook to therapueticTargets on update to remove signatures
…elonging to a report - Legend records include default value that is enforced by unique index and util functions to ensure only 1 record can have True value - Update uploadLegendImage middleware function - Update legend router and routes - Update legend unit tests - Update model associations
- Update unique constraint index field to default - Code lint
- Additional default: true filter for other legends in beforeUpdate hook to update only records with default: true to prevent excessive updates - Create legend images sequentially to ensure that default true constraint apply properly - Update uploadLegendImage documentation params - Update swagger - Code lint
- Update pathwayAnalysis unit tests
- Convert ensureDefaultExists to static function - Wrap crud functions in routes in the same transaction as ensureDefaultExists - Update swagger json - Update error messages displaying in routes
- Add updateLegendImage helper that processes an uploaded file and updates the legend's data/format/filename (plus any metadata) within a transaction - Use it from the PUT route when a file is attached; otherwise fall back to a metadata-only update - Reload the instance after commit so the response reflects persisted state (fixes stale default flag in the response) - Add tests for image replacement and metadata-only update DEVSU-2310
…image-replacement [DEVSU-2310] add image data to PUT path
- add swagger doc DEVSU-2310
…analysis-legend Feature/devsu 2310 rework pathway analysis legend
This comment has been minimized.
This comment has been minimized.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #501 +/- ##
==========================================
- Coverage 77.23% 76.94% -0.30%
==========================================
Files 186 188 +2
Lines 6760 6891 +131
Branches 858 879 +21
==========================================
+ Hits 5221 5302 +81
- Misses 1445 1491 +46
- Partials 94 98 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
Author
|
demo db dump needs to be made, doing |
bnguyen-bcgsc
previously approved these changes
Jul 31, 2026
no-ticket
Member
Author
|
updated demo dump with help from @sshugsc
|
sshugsc
reviewed
Aug 6, 2026
| npx sequelize-cli db:migrate --migrations-path "$dir" --url "postgres://$IPR_SERVICE_USER:$IPR_SERVICE_PASS@$IPR_DATABASE_SERVER/$IPR_DATABASE_NAME" | ||
| # Handle latest migrations (check for batch subdirectories first) | ||
| if [ -d "$parent_folder/latest" ]; then | ||
| latest_batches=$(find "$parent_folder/latest" -maxdepth 1 -type d ! -name "latest" | sort) |
Contributor
There was a problem hiding this comment.
The migration execution order looks a bit unusual. It currently runs the latest folder before older versioned folders, which could cause issues when migrating a legacy database state. This is probably not a blocker right now since our database is already up to date, but it would be safer to run migrations in this order: legacy, versioned directories, then latest.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Notes - IPR - Version API v8.6.0
Bugfixes
[DEVSU-2931] - updated_by is not getting populated during user creation
[DEVSU-2953] - TO table reodering should remove signatures from report
New Feature
[DEVSU-2310] - make pathway_legend choosable/uploadable in the client (part 1, next patch coming close behind)
Tasks
[DEVSU-2914] - add 'exon' column to IPR api
[DEVSU-2928] - datafix/migration - move current reports.seqQC contents into reports_seqqc