-
Notifications
You must be signed in to change notification settings - Fork 0
DEVSU-2864 Allow multiple projects to be associated with one variant-text item #499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bnguyen-bcgsc
wants to merge
8
commits into
develop
Choose a base branch
from
feature/DEVSU-2864-projects-variant-texts-many-to-many
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
5a0d499
- DEVSU-2864
bnguyen-bcgsc 72124f8
- Update unit test
bnguyen-bcgsc 900545f
- Update PUT route and unit tests
bnguyen-bcgsc f37694c
- Introduce a new scope for project model that includes id so eager l…
bnguyen-bcgsc d7f60ab
- Update DELETE unit test afterEach
bnguyen-bcgsc 4fb9d86
- Remove force: true for afterAll deletes in unit tests
bnguyen-bcgsc 77d6c56
- Remove force true for afterEach variantText delete in unit tests
bnguyen-bcgsc 7b625e2
- Update GET routes to allow all users to get all variantTexts regard…
bnguyen-bcgsc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| const {DEFAULT_MAPPING_COLUMNS, DEFAULT_MAPPING_OPTIONS} = require('../base'); | ||
|
|
||
| module.exports = (sequelize, Sq) => { | ||
| return sequelize.define( | ||
| 'projectVariantTextJoin', | ||
| { | ||
| ...DEFAULT_MAPPING_COLUMNS, | ||
| projectId: { | ||
| name: 'projectId', | ||
| field: 'project_id', | ||
| type: Sq.INTEGER, | ||
| unique: false, | ||
| allowNull: false, | ||
| references: { | ||
| model: 'projects', | ||
| key: 'id', | ||
| }, | ||
| }, | ||
| variantTextId: { | ||
| name: 'variantTextId', | ||
| field: 'variant_text_id', | ||
| type: Sq.INTEGER, | ||
| unique: false, | ||
| allowNull: false, | ||
| references: { | ||
| model: 'variant_texts', | ||
| key: 'id', | ||
| }, | ||
| }, | ||
| }, | ||
| { | ||
| ...DEFAULT_MAPPING_OPTIONS, | ||
| tableName: 'project_variant_text_join', | ||
| scopes: { | ||
| public: { | ||
| attributes: { | ||
| exclude: ['id', 'deletedAt'], | ||
| }, | ||
| }, | ||
| }, | ||
| indexes: [ | ||
| { | ||
| name: 'idx_project_id_join', | ||
| fields: ['project_id'], | ||
| }, | ||
| { | ||
| name: 'idx_variant_text_id_join', | ||
| fields: ['variant_text_id'], | ||
| }, | ||
| ], | ||
| }, | ||
| ); | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.