bugfix/DEVSU-2778-pori-report-updates-emails-are-not-sending

[sshugsc]

DEVSU-2778:

• move sendEmail to another file to avoid circular dependency

[codecov-commenter]

Codecov Report

❌ Patch coverage is 60.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.29%. Comparing base (f3dd674) to head (6e1785c).

Files with missing lines	Patch %	Lines
app/queue.js	0.00%	4 Missing ⚠️
app/libs/mailer.js	85.71%	1 Missing ⚠️
app/routes/email/index.js	50.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #473      +/-   ##
===========================================
+ Coverage    77.23%   77.29%   +0.06%     
===========================================
  Files          186      187       +1     
  Lines         6760     6756       -4     
  Branches       858      856       -2     
===========================================
+ Hits          5221     5222       +1     
+ Misses        1445     1440       -5     
  Partials        94       94              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[elewis2]

I'm getting this error when I try to create a report ERROR tests/test_ipr/test_upload_with_cnv_images_DEVSU-2610.py::TestCreateReport::test_multivariant_multiconditionset_statements_loaded - requests.exceptions.HTTPError: 400 Client Error: Bad Request for url: https://iprdev-api.bcgsc.ca/api/reports addJobToEmailQueue is not a function

--config issue on my end, but once this was fixed emails were still not sent for report upload or assignment

[elewis2]

may need other changes in the repo to work

[bnguyen-bcgsc]

Yes I just got this error from the api response as well: "{"message":"Error while sending email: TypeError: sendEmail is not a function"}"

[sshugsc]

When testing this feature, it requires .env setting with:

IPR_EMAIL_DOMAIN
IPR_EMAIL_EHOST
REDIS_HOST
REDIS_ENABLE_QUEUE

Also, users will only receive email notifications when they subscribe with the report's project and template.

[github-actions]

Unit Test Results

    1 files  ±0    63 suites  ±0   4m 5s ⏱️ +16s
641 tests ±0  640 ✔️ ±0  1 💤 ±0  0 ❌ ±0 
638 runs  ±0  637 ✔️ ±0  1 💤 ±0  0 ❌ ±0 

Results for commit 6e1785c. ± Comparison against base commit f3dd674.