Use configured tools for ThinLTO indexing - #852
Open
cerisier wants to merge 2 commits into
Open
Conversation
cerisier
marked this pull request as ready for review
August 21, 2026 12:29
lilygorsheneva
approved these changes
Aug 24, 2026
lilygorsheneva
left a comment
lilygorsheneva
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, might need to resolve merge confilcts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ThinLTO indexing shares link finalization, but tool lookup currently uses the final link action instead of the indexing action. A rule-based toolchain with a dedicated indexing driver therefore runs the ordinary linker, and files owned only by that indexing tool are omitted from the legacy
linker_filesinput set.Use the actual action name for tool selection and associate all three ThinLTO indexing actions with
linker_files. Ordinary link and archive actions are unchanged. Focused analysis coverage assigns distinct tools to executable linking and indexing, and covers all three file-group mappings.