Bump nodeps rules_apple and rules_swift deps - #30910
Open
keith wants to merge 2 commits into
Open
Conversation
Both of these repos had fixes for 9.x that require these newer versions. These nodeps versions matter because rules_cc -> protobuf -> googleapis -> grpc -> these repos gets pulled into everything by default, and in older versions this has a windows specific failure even if you never actually use them.
github-actions
Bot
added
the
awaiting-review
Member
Author
|
looks like this would require bumping the version of protobuf in the MODULE.tools as well, so idk if that's an issue or not. I could have gone lower here but I chose the same that's in the main MODULE.bazel here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both of these repos had fixes for 9.x that require these newer versions.
These nodeps versions matter because rules_cc -> protobuf -> googleapis
-> grpc -> these repos gets pulled into everything by default, and in
older versions this has a windows specific failure even if you never
actually use them.